Cannot build after pleaserun updates

[PavelVanecek]

Sometimes between Apr 30 and May 20 our builds stopped working. I am running the 4.4 branch only.
I've been following the guide and came up with this Dockerfile (which used to work for several months just fine):

FROM node:4.3 # comes from debian:jessie
RUN apt-get update && apt-get install -y zip ruby ruby-dev rubygems
RUN gem install pleaserun fpm
WORKDIR /kibana
COPY . .
RUN npm install
CMD ["npm", "run", "build:ospackages", "--", "--deb"]

I am suspicious that it has something to do with new versions of pleaserun.
These are errors I am seeing with pleaserun versions:

1. pleaserun:0.0.24

Running "_build:osPackages" task
# ...
{:timestamp=>"2016-05-23T10:51:05.582995+0000", :message=>"Invalid package configuration: Cannot package the path '/kibana/build/services/systemd/lib', does it exist?", :level=>:error}
Warning: Command failed: fpm --force --package /kibana/target -s dir --name kibana --description Explore and visualize your Elasticsearch data. --version 4.4.3-snapshot --url https://www.elastic.co --vendor Elasticsearch, Inc. --maintainer Kibana Team <[email protected]> --license Apache 2.0 --after-install /kibana/build/userScripts/installer.sh --after-remove /kibana/build/userScripts/remover.sh --config-files /opt/kibana/config/kibana.yml -t deb --deb-priority optional -a x86_64 /kibana/build/kibana-4.4.3-snapshot-linux-x64/=/opt/kibana /kibana/build/services/sysv/etc/=/etc/ /kibana/build/services/systemd/lib/=/lib/� Use --force to continue.

When I browse the project, indeed the folder build/services/systemd/lib does not exist.

1. pleaserun:0.0.23 - 22

Running "_build:pleaseRun" task
# ...
/var/lib/gems/2.1.0/gems/pleaserun-0.0.22/lib/pleaserun/cli.rb:116:in `block in execute': undefined method `unit_path' for #<PleaseRun::CLI:0x00000000ef2130> (NoMethodError)
from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/lib/pleaserun/cli.rb:113:in `each'
    from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/lib/pleaserun/cli.rb:113:in `execute'
    from /var/lib/gems/2.1.0/gems/clamp-1.0.0/lib/clamp/command.rb:68:in `run'
    from /var/lib/gems/2.1.0/gems/clamp-1.0.0/lib/clamp/command.rb:133:in `run'
    from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/bin/pleaserun:6:in `<top (required)>'
    from /usr/local/bin/pleaserun:23:in `load'
    from /usr/local/bin/pleaserun:23:in `<main>'
Warning: Command failed: pleaserun --install --no-install-actions --install-prefix /kibana/build/services/systemd --overwrite --user kibana --sysv-log-path /var/log/kibana/ -p systemd -v default /opt/kibana/bin/kibana� Use --force to continue.�

My workaround is to rollback to pleaserun:0.0.21 and the build works:

RUN gem install pleaserun:0.0.21
# all OK now

I am not sure if this is pleaserun issue or kibana build configuration issue.

These changes seem related: #5322, #5307

Can you reproduce? What is the best way to fix it?

Some more details, I guess it might help debugging:

Correct build (with pleaserun 21) says:

Writing file {:destination=>"/kibana/build/services/systemd/lib/systemd/system/kibana.service"}

On the other hand, build with pleaserun 24 says:

Writing file {:destination=>"/kibana/build/services/systemd/etc/systemd/system/kibana.service"}

Pleaserun changelog (version 22) says:

systemd platform now defaults to targeting /etc/systemd/system for writing unit files

Commit jordansissel/pleaserun@1223773

[jbudz]

kibana/tasks/build/os_packages.js

Line 38 in 95132dd

const systemd = servicesByName.systemd.outputDir + '/lib/=/lib/';

needs to updated with the correct path, s/lib/etc

[PavelVanecek]

Rollback to pleaserun 21 no longer works since fpm now installs pleaserun 24 anyway: jordansissel/fpm@e2b1ca3.

I confirm that changes from #7276 fix our build too.