Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update pleaserun path to be compatible with 0.0.22+ #7276

Merged
merged 2 commits into from
Jul 6, 2016

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented May 24, 2016

pleaserun on jenkins will have to be updated before this gets merged to master
Closes #7265

@jbudz
Copy link
Member Author

jbudz commented May 25, 2016

jenkins, test it

@jbudz
Copy link
Member Author

jbudz commented Jun 9, 2016

jenkins, test it

1 similar comment
@LeeDr
Copy link

LeeDr commented Jun 9, 2016

jenkins, test it

@LeeDr
Copy link

LeeDr commented Jun 10, 2016

@jbudz I don't know why this is failing. I started another PR to take a screenshot when the app fails to load over and over again.

@LeeDr
Copy link

LeeDr commented Jun 10, 2016

This might be failing because of #7424

@LeeDr
Copy link

LeeDr commented Jun 16, 2016

@jbudz do you want to merge with master and see if the tests pass then

@jbudz jbudz force-pushed the update-pleaserun branch from 235aa2b to 953a337 Compare June 16, 2016 21:44
npm run build -- --skip-archives
gem install fpm -v 1.5.0
gem install pleaserun -v 0.0.24
npm run build:ospackages
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be npm run build -- --skip-archives ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, sure does.

@LeeDr
Copy link

LeeDr commented Jun 16, 2016

Maybe I did something wrong, but here's what I got;

The build completed OK and I have all the packages in target/

I installed dpkg -i target/kibana_5.0.0-alpha4-SNAPSHOT_amd64.deb and that went OK

service kibana start

I expected to see a yml file here, but it's not;

root@U14K:~/kibana# ls -l /etc/kibana/
total 0

journal shows;
FATAL CLI ERROR Error: ENOENT: no such file or directory, open '/etc/kibana/kibana.yml'

I found this in the build path, but no other current ones from the install;

root@U14K:~/integration-test# ls -l `find / -name kibana.yml`
-rw-r--r-- 1 root  root  3842 Jun 16 17:07 /home/leedr/kibana/build/kibana-5.0.0-alpha4-SNAPSHOT-darwin-x64/config/kibana.yml
-rw-r--r-- 1 root  root  3842 Jun 16 17:07 /home/leedr/kibana/build/kibana-5.0.0-alpha4-SNAPSHOT-linux-x64/config/kibana.yml
-rw-r--r-- 1 root  root  3842 Jun 16 17:07 /home/leedr/kibana/build/kibana-5.0.0-alpha4-SNAPSHOT-linux-x86/config/kibana.yml
-rw-r--r-- 1 root  root  3842 Jun 16 17:07 /home/leedr/kibana/build/kibana-5.0.0-alpha4-SNAPSHOT-windows/config/kibana.yml

@jbudz
Copy link
Member Author

jbudz commented Jul 1, 2016

@LeeDr we chatted about this briefly a bit ago, did purging kibana fix the issue for you?

@jbudz jbudz force-pushed the update-pleaserun branch from 1f9470f to 315fc5d Compare July 5, 2016 21:28
@LeeDr
Copy link

LeeDr commented Jul 5, 2016

@jbudz sorry, I'll get back to this and test it again now

@LeeDr
Copy link

LeeDr commented Jul 5, 2016

LGTM

@jbudz
Copy link
Member Author

jbudz commented Jul 6, 2016

This is waiting for pleaserun 0.0.24 on CI, when it's updated anyone feel free to merge. Snapshots are built only on master which is why this is green now.

@epixa
Copy link
Contributor

epixa commented Jul 6, 2016

Is there an infra ticket or something for that?

@jbudz
Copy link
Member Author

jbudz commented Jul 6, 2016

Just slack, I'll get one open for tracking

@elasticdog
Copy link
Contributor

Note that the new build kibana-ci has pleaserun 0.0.24 installed, but the old slave nodes connected to built-eu-00 do not. We're still working out some final kinks with ensuring pull requests are tested properly on the new system, but once that's in place, you should be able to merge this and we'll just disable to jobs on the old build system.

@spalger
Copy link
Contributor

spalger commented Jul 6, 2016

We've disabled job building on build-eu-00 for now, and are merging this to move forward with the new ci system. If things go hayward we will revert this pr and re-enable build-eu-00

@spalger spalger merged commit 5d853da into elastic:master Jul 6, 2016
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 7, 2016
@epixa epixa added v5.0.0 and removed v5.0.0 labels Aug 1, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
[build] update pleaserun path to be compatible with 0.0.22+

Former-commit-id: 5d853da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants