-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] update pleaserun path to be compatible with 0.0.22+ #7276
Conversation
jenkins, test it |
jenkins, test it |
1 similar comment
jenkins, test it |
@jbudz I don't know why this is failing. I started another PR to take a screenshot when the app fails to load over and over again. |
This might be failing because of #7424 |
@jbudz do you want to merge with master and see if the tests pass then |
npm run build -- --skip-archives | ||
gem install fpm -v 1.5.0 | ||
gem install pleaserun -v 0.0.24 | ||
npm run build:ospackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be npm run build -- --skip-archives
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sure does.
Maybe I did something wrong, but here's what I got; The build completed OK and I have all the packages in target/ I installed
I expected to see a yml file here, but it's not;
journal shows; I found this in the build path, but no other current ones from the install;
|
@LeeDr we chatted about this briefly a bit ago, did purging kibana fix the issue for you? |
@jbudz sorry, I'll get back to this and test it again now |
LGTM |
This is waiting for pleaserun 0.0.24 on CI, when it's updated anyone feel free to merge. Snapshots are built only on master which is why this is green now. |
Is there an infra ticket or something for that? |
Just slack, I'll get one open for tracking |
Note that the new build kibana-ci has pleaserun 0.0.24 installed, but the old slave nodes connected to built-eu-00 do not. We're still working out some final kinks with ensuring pull requests are tested properly on the new system, but once that's in place, you should be able to merge this and we'll just disable to jobs on the old build system. |
We've disabled job building on build-eu-00 for now, and are merging this to move forward with the new ci system. If things go hayward we will revert this pr and re-enable build-eu-00 |
[build] update pleaserun path to be compatible with 0.0.22+ Former-commit-id: 5d853da
pleaserun on jenkins will have to be updated before this gets merged to master
Closes #7265