Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vislib performs width/height calculations redundantly #6555

Closed
trevan opened this issue Mar 16, 2016 · 1 comment
Closed

vislib performs width/height calculations redundantly #6555

trevan opened this issue Mar 16, 2016 · 1 comment
Assignees
@ppisljar
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@trevan
Copy link
Contributor

trevan commented Mar 16, 2016

In addition to my find in #6492, I noticed that Kibana is extremely inefficient in fixing sizes of widths and heights.

One example is the XAxis.prototype.fitTitles function (https://github.com/elastic/kibana/blob/master/src/ui/public/vislib/lib/x_axis.js#L437). This is called for every single visualization. It then grabs all .vis-wrapper elements on the page (one for each visualization) and fixes up the height/width values for the axis's and charts. This means that for a dashboard with n visualizations, it will run it n*n times.
@trevan trevan mentioned this issue Mar 17, 2016
Closed
@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience P2 labels Mar 18, 2016
@panda01 panda01 self-assigned this Apr 30, 2016
@thomasneirynck thomasneirynck added the Feature:Vislib Vislib chart implementation label Aug 12, 2016
@ppisljar ppisljar self-assigned this Sep 7, 2016
@tbragin tbragin added the Feature:Visualizations Generic visualization features (in case no more specific feature label is available) label Nov 9, 2016
@ppisljar ppisljar mentioned this issue Nov 30, 2016
Merged
@ppisljar
Copy link
Member

ppisljar commented Dec 9, 2016

fixed by #9044

@ppisljar ppisljar closed this as completed Dec 9, 2016
cee-chen added a commit that referenced this issue Feb 15, 2023
@cee-chen
Upgrade EUI to v75.1.0 (#151200)
af25a3e 
## Summary

`[email protected]` ⏩ `[email protected]`

---

## [`75.1.0`](https://github.com/elastic/eui/tree/v75.1.0)

- Added padding to `EuiStep` title to better align with icon
([#6555](elastic/eui#6555))
- Added a new `lineNumbers.annotations` API to `EuiCodeBlock`. This new
feature displays an informational icon next to the specified line
number(s), providing more context via popover
([#6580](elastic/eui#6580))

**Bug fixes**

- Fixed bug in `EuiRange` where styles were applied incorrectly when
custom ticks were passed but `showTicks` were false
([#6588](elastic/eui#6588))
- Fixed `fleetApp` and `agentApp` icons that were swapped
([#6590](elastic/eui#6590))

**CSS-in-JS conversions**

- Converted `EuiSteps` to Emotion; Removed `$euiStepStatusColorsToFade`,
`$euiStepNumberSize`, `$euiStepNumberSmallSize`, and
`$euiStepNumberMargin`
([#6555](elastic/eui#6555))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@panda01 @tbragin @rashidkpc @thomasneirynck @trevan @ppisljar