[jenkins] ensure that JDK8 is in path #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
upgrade/selenium
branch
2 times, most recently
from
fa0705f to
5c93813
Compare
| @@ -5,8 +5,8 @@ module.exports = function (grunt) { | |||
| grunt.option('os-packages', true); | |||
|
|
|||
| grunt.task.run(compact([ | |||
| 'test', | |||
There was a problem hiding this comment.
Did you intend to change this?
|
The build failure seems to indicate that something is still looking for the old version of selenium. |
spalger
force-pushed
the
upgrade/selenium
branch
4 times, most recently
from
7750312 to
f366402
Compare
spalger
force-pushed
the
upgrade/selenium
branch
from
f366402 to
f2651bd
Compare
spalger
force-pushed
the
upgrade/selenium
branch
2 times, most recently
from
e78e473 to
f53b8c1
Compare
|
The remaining failure here is due to elastic/elasticsearch#17217. Would like to merge and deal with these failures in another pr. |
|
LGTM |
spalger
added a commit
that referenced
this pull request
Mar 21, 2016
[jenkins] ensure that JDK8 is in path
cee-chen
added a commit
that referenced
this pull request
Feb 15, 2023
## Summary `[email protected]` ⏩ `[email protected]` --- ## [`75.1.0`](https://github.com/elastic/eui/tree/v75.1.0) - Added padding to `EuiStep` title to better align with icon ([#6555](elastic/eui#6555)) - Added a new `lineNumbers.annotations` API to `EuiCodeBlock`. This new feature displays an informational icon next to the specified line number(s), providing more context via popover ([#6580](elastic/eui#6580)) **Bug fixes** - Fixed bug in `EuiRange` where styles were applied incorrectly when custom ticks were passed but `showTicks` were false ([#6588](elastic/eui#6588)) - Fixed `fleetApp` and `agentApp` icons that were swapped ([#6590](elastic/eui#6590)) **CSS-in-JS conversions** - Converted `EuiSteps` to Emotion; Removed `$euiStepStatusColorsToFade`, `$euiStepNumberSize`, `$euiStepNumberSmallSize`, and `$euiStepNumberMargin` ([#6555](elastic/eui#6555))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something changed recently and selenium (the same version we've been using for a while?) no longer runs on JDK7. Since this is the default JDK we need to intentionally put JDK8 into the PATH when we run our tests on jeknins.