Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for split charts come and go depending on other split charts #6556

Closed
trevan opened this issue Mar 17, 2016 · 0 comments · Fixed by #6654
Closed

Labels for split charts come and go depending on other split charts #6556

trevan opened this issue Mar 17, 2016 · 0 comments · Fixed by #6654
Assignees
@stormpython
Labels
bug Fixes for quality problems that affect the customer experience PR sent

Comments

@trevan
Copy link
Contributor

trevan commented Mar 17, 2016

While looking at #6555, I noticed the code in chart_title_split.js (https://github.com/elastic/kibana/blob/master/src/ui/public/vislib/lib/layout/splits/column_chart/chart_title_split.js#L27) which globally removes the .x-axis-chart-title or .y-axis-chart-title depending on what the chart wants.

That made me think that if I had a dashboard with alternate split charts (one split by row, the other split by column), I should see the titles come and go. And, it turns out, that is exactly what happens.

bouncing_labels
@rashidkpc rashidkpc added the bug Fixes for quality problems that affect the customer experience label Mar 17, 2016
stormpython added a commit to stormpython/kibana that referenced this issue Mar 24, 2016
@stormpython
Closes elastic#6556. Fixes issue with global x and y axis selection.
2ffbb76
@stormpython stormpython mentioned this issue Mar 24, 2016
Merged
@elastic-jasper elastic-jasper mentioned this issue Apr 1, 2016
Closed
elastic-jasper added a commit that referenced this issue Apr 1, 2016
@elastic-jasper
Backport PR #6654
e6bfb3e 
---------

**Commit 1:**
Troubleshooting

* Original sha: 81a9f29
* Authored by Shelby Sturgis <[email protected]> on 2016-03-22T21:44:17Z

**Commit 2:**
Merge branch 'master' into issue/6556

* Original sha: f628114
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T16:48:41Z

**Commit 3:**
troubleshooting

* Original sha: 152f2b6
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T17:13:01Z

**Commit 4:**
Closes #6556. Fixes issue with global x and y axis selection.

* Original sha: 2ffbb76
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:44:54Z

**Commit 5:**
Merge branch 'master' into issue/6556

* Original sha: da025aa
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:45:12Z

**Commit 6:**
Merge branch 'master' into issue/6556

* Original sha: cf4a152
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:45:50Z

**Commit 7:**
fixing tests

* Original sha: b2f26e7
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T16:55:30Z

**Commit 8:**
Merge branch 'master' into issue/6556

* Original sha: a56c5d5
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T17:51:21Z

**Commit 9:**
refactoring

* Original sha: b42f5bf
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T21:43:59Z

**Commit 10:**
Merge branch 'master' into issue/6556

* Original sha: 7f96a11
* Authored by Shelby Sturgis <[email protected]> on 2016-03-28T22:59:03Z
elastic-jasper added a commit that referenced this issue Apr 1, 2016
@elastic-jasper
Backport PR #6654
fa99127 
---------

**Commit 1:**
Troubleshooting

* Original sha: 81a9f29
* Authored by Shelby Sturgis <[email protected]> on 2016-03-22T21:44:17Z

**Commit 2:**
Merge branch 'master' into issue/6556

* Original sha: f628114
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T16:48:41Z

**Commit 3:**
troubleshooting

* Original sha: 152f2b6
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T17:13:01Z

**Commit 4:**
Closes #6556. Fixes issue with global x and y axis selection.

* Original sha: 2ffbb76
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:44:54Z

**Commit 5:**
Merge branch 'master' into issue/6556

* Original sha: da025aa
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:45:12Z

**Commit 6:**
Merge branch 'master' into issue/6556

* Original sha: cf4a152
* Authored by Shelby Sturgis <[email protected]> on 2016-03-24T22:45:50Z

**Commit 7:**
fixing tests

* Original sha: b2f26e7
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T16:55:30Z

**Commit 8:**
Merge branch 'master' into issue/6556

* Original sha: a56c5d5
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T17:51:21Z

**Commit 9:**
refactoring

* Original sha: b42f5bf
* Authored by Shelby Sturgis <[email protected]> on 2016-03-25T21:43:59Z

**Commit 10:**
Merge branch 'master' into issue/6556

* Original sha: 7f96a11
* Authored by Shelby Sturgis <[email protected]> on 2016-03-28T22:59:03Z
@elastic-jasper elastic-jasper mentioned this issue Apr 1, 2016
Closed
This was referenced Apr 4, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stormpython stormpython

Labels
bug Fixes for quality problems that affect the customer experience PR sent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes global chart title selection stormpython/kibana
3 participants
@rashidkpc @trevan @stormpython