Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Task Manager MGet Claimer Functional Tests.x-pack/test/task_manager_claimer_mget/test_suites/task_manager/task_partitions·ts - task_manager with mget task claimer task partitions should run tasks with partitions assigned to this kibana node #192023

Closed
kibanamachine opened this issue Sep 3, 2024 · 9 comments · Fixed by #196399
Closed

Failing test: Task Manager MGet Claimer Functional Tests.x-pack/test/task_manager_claimer_mget/test_suites/task_manager/task_partitions·ts - task_manager with mget task claimer task partitions should run tasks with partitions assigned to this kibana node #192023

kibanamachine opened this issue Sep 3, 2024 · 9 comments · Fixed by #196399
Assignees
@mikecote
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 3, 2024 •
edited
Loading

A test failed on a tracked branch

Error: retry.try reached timeout 120000 ms
Error: The task ID: 0 has not run yet
    at task_partitions.ts:211:17
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:98:21)
    at RetryService.try (retry.ts:51:12)
    at task_partitions.ts:195:9
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:84:7)
    at RetryService.try (retry.ts:51:12)
    at task_partitions.ts:195:9

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Sep 3, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 3, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Sep 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 3, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@delanni
Copy link
Contributor

delanni commented Sep 4, 2024

/skip

kibanamachine added a commit that referenced this issue Sep 4, 2024
@kibanamachine
skip failing test suite (#192023)
8d7fbb7
@kibanamachine
Copy link
Contributor Author

Skipped

main: 8d7fbb7

@ymao1 ymao1 mentioned this issue Sep 6, 2024
Merged
ymao1 added a commit that referenced this issue Sep 6, 2024
@ymao1
Revert ba0485e (#192288)
2ace62c 
## Summary

Reverting PR #191669 because it is
causing a flaky test #192023
that requires additional investigation.

Unskipped the flaky test and ran the flaky test runner against this PR
@ymao1
Copy link
Contributor

ymao1 commented Sep 9, 2024

Resolved in #192303

@ymao1 ymao1 closed this as completed Sep 9, 2024
@kibanamachine kibanamachine reopened this Oct 10, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@mikecote mikecote assigned mikecote and unassigned ymao1 Oct 18, 2024
@mikecote mikecote mentioned this issue Oct 18, 2024
Merged
mikecote added a commit to mikecote/kibana that referenced this issue Oct 21, 2024
@mikecote
Improve task manager functional tests in preperation for mget task cl…
9df52dd 
…aimer being the default (elastic#196399)

Resolves elastic#184942
Resolves elastic#192023
Resolves elastic#195573

In this PR, I'm improving the flakiness found in our functional tests in
preperation for mget being the default task claimer that all these tests
run with (elastic#194625). Because the
mget task claimer works differently and also polls more frequently, we
end-up in situations where tasks run faster than they were with
update_by_query, creating more race conditions that are now fixed in
this PR.

Issues were surfaced via elastic#190148
where I set `mget` as the default task claiming strategy.

Flaky test runs (some of these failed on other tests that are flaky):
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7151
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7169
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7172
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7175
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7176
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7185
(for
elastic@0fcf1ae)

(cherry picked from commit 3b8cf12)

# Conflicts:
#	x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_flapping.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@mikecote @delanni @ymao1 @elasticmachine @kibanamachine