Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Alerting API Integration Tests - Alerting - group4.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_flapping·ts - Alerting alerts_as_data alerts as data flapping should allow rule specific flapping to override space flapping #195573

Closed
kibanamachine opened this issue Oct 9, 2024 · 14 comments · Fixed by #196399 or #198013
Closed

Failing test: X-Pack Alerting API Integration Tests - Alerting - group4.x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_flapping·ts - Alerting alerts_as_data alerts as data flapping should allow rule specific flapping to override space flapping #195573

kibanamachine opened this issue Oct 9, 2024 · 14 comments · Fixed by #196399 or #198013
Assignees
@mikecote
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 9, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expected 6 to sort of equal 4
    at Assertion.assert (expect.js:100:11)
    at Assertion.eql (expect.js:244:8)
    at Context.<anonymous> (alerts_as_data_flapping.ts:605:33)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:74:16) {
  actual: '6',
  expected: '4',
  showDiff: true
}

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 9, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 9, 2024
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 9, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 9, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.x

mistic added a commit that referenced this issue Oct 17, 2024
@mistic
skip flaky suite (#195573)
f9936d6
kibanamachine added a commit that referenced this issue Oct 17, 2024
@kibanamachine
skip failing test suite (#195573)
a375de2
@kibanamachine
Copy link
Contributor Author

Skipped

main: a375de2
8.x: 2c69d9a

kibanamachine added a commit that referenced this issue Oct 17, 2024
@kibanamachine
skip failing test suite (#195573)
2c69d9a
@mikecote mikecote self-assigned this Oct 18, 2024
@mikecote mikecote mentioned this issue Oct 18, 2024
Merged
mikecote added a commit to mikecote/kibana that referenced this issue Oct 21, 2024
@mikecote
Improve task manager functional tests in preperation for mget task cl…
9df52dd 
…aimer being the default (elastic#196399)

Resolves elastic#184942
Resolves elastic#192023
Resolves elastic#195573

In this PR, I'm improving the flakiness found in our functional tests in
preperation for mget being the default task claimer that all these tests
run with (elastic#194625). Because the
mget task claimer works differently and also polls more frequently, we
end-up in situations where tasks run faster than they were with
update_by_query, creating more race conditions that are now fixed in
this PR.

Issues were surfaced via elastic#190148
where I set `mget` as the default task claiming strategy.

Flaky test runs (some of these failed on other tests that are flaky):
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7151
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7169
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7172
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7175
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7176
-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/7185
(for
elastic@0fcf1ae)

(cherry picked from commit 3b8cf12)

# Conflicts:
#	x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group4/alerts_as_data/alerts_as_data_flapping.ts
@kibanamachine kibanamachine reopened this Oct 23, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.16

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - 8.16

@delanni
Copy link
Contributor

delanni commented Oct 25, 2024

it seems to be back

@delanni
Copy link
Contributor

delanni commented Oct 25, 2024

/skip

kibanamachine added a commit that referenced this issue Oct 25, 2024
@kibanamachine
skip failing test suite (#195573)
043f059
kibanamachine added a commit that referenced this issue Oct 25, 2024
@kibanamachine
skip failing test suite (#195573)
10f234c
@kibanamachine
Copy link
Contributor Author

Skipped

8.16: 043f059
main: 10f234c

@mikecote mikecote mentioned this issue Oct 28, 2024
Merged
@cnasikas cnasikas removed the v8.16.0 label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
6 participants
@mikecote @mistic @delanni @cnasikas @elasticmachine @kibanamachine