[Response Ops][Task Manager] Setting task status directly to running in mget claim strategy
#191669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymao1
changed the title
running in mget claim strategy
ymao1
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
js-jankisalvi
approved these changes
Sep 2, 2024
|
@elasticmachine merge upstream |
mikecote
approved these changes
Sep 3, 2024
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @ymao1 |
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Sep 6, 2024
…`running` in `mget` claim strategy (elastic#191669)" This reverts commit ba0485e.
ymao1
added a commit
to ymao1/kibana
that referenced
this pull request
Sep 6, 2024
… `running` in `mget` claim strategy (elastic#191669)" This reverts commit 689f227.
ymao1
added a commit
that referenced
this pull request
Sep 9, 2024
… `running` in `mget` claim strategy (#192303) Re-doing this PR: #191669 Reverted because it was causing a flaky test. After a lot of investigation, it looks like the flakiness was caused by interference from long-running tasks scheduled as part of other tests. The task partitions test uses task IDs `1`, `2` and `3` and the tasks were being short circuited when there were other tasks with UUIDs that started with `1`, `2` or `3` due to the logic in the task runner that tries to prevent duplicate recurring tasks from running. That logic just used `startsWith` to test for duplicates where the identifier is `${task.id}::${task.executionUUID}`. Updated that logic instead to check for duplicate `task.id` instead of just using `startsWith` in this commit: 1646ae9 --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #184739
Summary
During the
mgettask claim strategy, we set the task directly torunningwith the appropriateretryAtvalue instead of setting it toclaimingand letting the task runner set the task torunning. This removes a task update from the claiming process. Updates the task runner to skip themarkTaskAsRunningfunction if the claim strategy ismgetand move the task directly to "ready to run".