[Infra] Replace MetricsUIAggregation in favor of estypes.AggregationsAggregate
#190311
Assignees
Labels
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
technical debt
Improvement of the software architecture and operational architecture
Comments
crespocarlos
added
the
technical debt
crespocarlos
added
Team:obs-ux-infra_services
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
added
the
technical debt
crespocarlos
changed the title
MetricsUIAggregation in favor of estypes.AggregationsAggregateMetricsUIAggregation in favor of estypes.AggregationsAggregate
This was referenced Aug 14, 2024
stephmilovic
pushed a commit
to stephmilovic/kibana
that referenced
this issue
Aug 21, 2024
…onsAggregate` (elastic#190495) Closes [elastic#190311](elastic#190311) ## Summary This PR replaces `MetricsUIAggregation` in favor of `estypes.AggregationsAggregate`. Now the `MetricsUIAggregation` uses estypes.AggregationsAggregate and the `MetricsUIAggregationRT `is removed which also allows us to remove the `ESAggregationRT`. Instead of maintaining the runtime types we now rely on the types provided by elasticsearch. A follow-up issue will be linked here to address the other aggregation types related changes: [elastic#190497](elastic#190497) ## Testing - Check the types - Host page should load with no errors - To test if the API works use the request provided in the [x-pack/plugins/observability_solution/infra/server/routes/infra/README.md](https://github.com/elastic/kibana/compare/main...jennypavlova:kibana:190311-infra-replace-metricsuiaggregation-in-favor-of-estypesaggregationsaggregate?expand=1#diff-e853fdd3f4073eff8ff8a4df6a657f8cb5fefaa231be0116fe3692ae929f26a8) - if the body is not valid 400 is returned --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
In Infra, there is extensive code for typing Elasticsearch request parameters using
io-ts. This code was created a few years ago (git history), before the Elasticsearch client implemented ts types.While one of the benefits of using
io-tsis runtime validation, in this case, the benefit doesn't outweigh the cost of maintaining this code. We might be better off relying on the types provided by the elasticsearch library.AC
MetricsUIAggregationin favor of estypes.AggregationsAggregateMetricsUIAggregationrelated types definitions are removedThe text was updated successfully, but these errors were encountered: