-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New type definitions #1358
Merged
Merged
New type definitions #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix yaml parser and crash on failure * Log response in case of ResponseError * Updated cleanup * Updated skip list * Updated skip list * Updated skip list
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-1358-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 f86a79cb26821ed7a748f54a6dbf51cd61471460
# Push it to GitHub
git push --set-upstream origin backport-1358-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x Then, create a pull request where the |
delvedor
added a commit
that referenced
this pull request
Mar 24, 2021
Merged
1 task
miloszmarcinkowski
added a commit
to elastic/kibana
that referenced
this pull request
Sep 5, 2024
…types` (#192059) Closes #190497 ## Summary This PR replaces infra aggregation types with types provided by the [Elasticsearch client](elastic/elasticsearch-js#1358). ### Testing not applicable ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces type definitions for requests, responses, and the client itself. There are different noticeable changes, almost all of them will cause a breaking change typescript wise:
RequestParams
export has been removedtypes
export has been added, containing the full type definition of Elasticsearch endpoints.The types are not yet complete, there is still a lot of work to do. We are publishing them early to solicit feedback sooner rather than later. If a definition is broken for you and you can't wait for a fix, please use the
@ts-expect-error
comment. In this way, as soon as the definition is fixed, you will get a compilation error.There are some APIs (brand new ones) that are not yet covered, those API will have the
TODO
type, which is an alias toRecord<string, any>
.