Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Using the data grid full screen mode causes the top nav buttons to disappear #172716

Closed
davismcphee opened this issue Dec 6, 2023 · 2 comments · Fixed by #176324
Closed

[Discover] Using the data grid full screen mode causes the top nav buttons to disappear #172716

davismcphee opened this issue Dec 6, 2023 · 2 comments · Fixed by #176324
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:UnifiedDataTable impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Serverless Work as part of the Serverless project for its initial release Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@davismcphee
Copy link
Contributor

Opening and closing the data grid full screen mode in Discover causes the top nav buttons to disappear, requiring a page refresh to restore them:

full_screen.mp4

I encountered this in 8.12, but it's likely the issue the issue exists in previous versions too.
@davismcphee davismcphee added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application loe:needs-research This issue requires some research before it can be worked on or estimated impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. :DataDiscovery/fix-it-week Feature:UnifiedDataTable v8.12.0 labels Dec 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee mentioned this issue Jan 24, 2024
Closed
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed v8.12.0 impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 1, 2024
@kertal
Copy link
Member

kertal commented Feb 2, 2024

I was having a look at it, and I don't think this is related to Discover code, it's just surfacing here. When you go to fullscreen mode, there are just CSS classed added to DOM elements. For some mysterious reason, this leads to the navigation to disappear, to be removed of the DOM. I don't know what dark magic does that, but it's not something in Discover. Reassigning to @elastic/appex-sharedux because owning the navigation plugin, a brief look at their code, I couldn't see anything that could be some sort of dark magic dom destroying like

@kertal kertal added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed :DataDiscovery/fix-it-week labels Feb 2, 2024
@petrklapka petrklapka added the Project:Serverless Work as part of the Serverless project for its initial release label Feb 5, 2024
@Dosant Dosant self-assigned this Feb 6, 2024
@Dosant Dosant mentioned this issue Feb 6, 2024
Merged
Dosant added a commit that referenced this issue Feb 7, 2024
@Dosant
[Discover] fix using the data grid full screen mode causes the top na…
4b17d54 
…v buttons to disappear (#176324)

## Summary

fix #172716

The header_action_menu didn't reset the state correctly when it was
unmounted. This caused an state bug when remounting and as the result
#172716 the action menu didn't
render
fkanout pushed a commit to fkanout/kibana that referenced this issue Feb 7, 2024
@Dosant @fkanout
[Discover] fix using the data grid full screen mode causes the top na…
a4d7666 
…v buttons to disappear (elastic#176324)

## Summary

fix elastic#172716

The header_action_menu didn't reset the state correctly when it was
unmounted. This caused an state bug when remounting and as the result
elastic#172716 the action menu didn't
render
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@Dosant @CoenWarmer
[Discover] fix using the data grid full screen mode causes the top na…
8938f05 
…v buttons to disappear (elastic#176324)

## Summary

fix elastic#172716

The header_action_menu didn't reset the state correctly when it was
unmounted. This caused an state bug when remounting and as the result
elastic#172716 the action menu didn't
render
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@Dosant @fkanout
[Discover] fix using the data grid full screen mode causes the top na…
f20c680 
…v buttons to disappear (elastic#176324)

## Summary

fix elastic#172716

The header_action_menu didn't reset the state correctly when it was
unmounted. This caused an state bug when remounting and as the result
elastic#172716 the action menu didn't
render
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Feature:UnifiedDataTable impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Serverless Work as part of the Serverless project for its initial release Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
5 participants
@kertal @Dosant @elasticmachine @davismcphee @petrklapka