[Discover] fix using the data grid full screen mode causes the top nav buttons to disappear #176324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
Dosant
changed the title
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
sebelga
approved these changes
Feb 7, 2024
kibanamachine
added
v8.13.0
backport:skip
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
…v buttons to disappear (elastic#176324) ## Summary fix elastic#172716 The header_action_menu didn't reset the state correctly when it was unmounted. This caused an state bug when remounting and as the result elastic#172716 the action menu didn't render
|
Thanks for fixing it! Can we also backport it? |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…v buttons to disappear (elastic#176324) ## Summary fix elastic#172716 The header_action_menu didn't reset the state correctly when it was unmounted. This caused an state bug when remounting and as the result elastic#172716 the action menu didn't render
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…v buttons to disappear (elastic#176324) ## Summary fix elastic#172716 The header_action_menu didn't reset the state correctly when it was unmounted. This caused an state bug when remounting and as the result elastic#172716 the action menu didn't render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #172716
The header_action_menu didn't reset the state correctly when it was unmounted. This caused an state bug when remounting and as the result #172716 the action menu didn't render