Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Remove the inventory node details flyout #166807

Closed
jennypavlova opened this issue Sep 20, 2023 · 1 comment · Fixed by #166965
Closed

[Infra UI] Remove the inventory node details flyout #166807

jennypavlova opened this issue Sep 20, 2023 · 1 comment · Fixed by #166965
Assignees
@jennypavlova
Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Sep 20, 2023 •
edited
Loading

Description

After replacing the inventory flyout with the existing asset details flyout we should remove the old implementation.

AC
@jennypavlova jennypavlova added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova changed the title [Infra UI] Remove the old inventory flyout [Infra UI] Remove the inventory node details flyout Sep 20, 2023
@jennypavlova jennypavlova mentioned this issue Sep 20, 2023
Closed
@jennypavlova jennypavlova self-assigned this Sep 22, 2023
@jennypavlova jennypavlova mentioned this issue Sep 26, 2023
Merged
jennypavlova added a commit that referenced this issue Sep 28, 2023
@jennypavlova @kibanamachine
[Infra UI] Replace node details flyout with asset details flyout in t…
549195c 
…he inventory page (#166965)

Closes #161754 
Closes #166807

To make the testing and review easier I merged the old components
[cleanup PR](jennypavlova#5) into this
one

## Summary
This PR replaces the old node details view with the asset details flyout

### Old

![image](https://github.com/elastic/kibana/assets/14139027/ffbead5b-6f89-4397-b1a4-2ade74f7f227)

### New 

![image](https://github.com/elastic/kibana/assets/14139027/89fa52cd-a462-499e-900a-e26c70d17791)

### Testing

1. Go to inventory
2. Click on a host in the waffle map
3. Click on any **host**
- These changes are related only if a `Host` is selected- in the case of
a pod the view shouldn't be changed:

![image](https://github.com/elastic/kibana/assets/14139027/d1b90b65-1bbf-4fbf-a0c6-6b95afe6162e)

4. Check the new flyout functionality 



https://github.com/elastic/kibana/assets/14139027/3557821c-7964-466e-8514-84c2f81bc2fd

Note: the selected host should have a border like in the previous
version (this I fixed in the [last
commit](ff4753a))
so it should be added if there is a selected node:
<img width="1193" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/6646fe47-6333-435a-a5ec-248339402224">

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
2 participants
@jennypavlova @elasticmachine