Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Show metadata for a single host on the host UI #150893

Closed
jennypavlova opened this issue Feb 10, 2023 · 1 comment · Fixed by #152956
Closed

[Infrastructure UI] Show metadata for a single host on the host UI #150893

jennypavlova opened this issue Feb 10, 2023 · 1 comment · Fixed by #152956
Assignees
@jennypavlova
Labels
Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Feb 10, 2023 •
edited
Loading

📓 Summary

The host metadata will be useful for the SREs during their investigation of certain host behavior and filter the hosts based on it. We want to achieve a similar experience to the inventory view when a single host is selected. The filtering functionality will be added in a separate issue.
The metadata section should have information about the host and fields and values about the host (which will be used for filtering) similar to:
image
image

The flyout will open when an icon button next to the hostname is clicked - similar to discover (Expand Button):

Image
Image

🎨 Design

Figma

👨‍💻 Implementation hints

  • In order to get the metadata we can use the metadata api

  • For opening/closing the flyout we can consider using a data grid instead of the in-memory table. The data grid will support the flyout functionality- try the eye icon (it will also help us to add the filters inside the table - it will be a separate issue) We decided to skip this change for now

  • We can use the table we have and open the flyout using a table action

✔️ Acceptance criteria

  • A single host metadata should be visible after a host selection
  • The metadata should contain different sections (agent/cloud based on the host)
@jennypavlova jennypavlova added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Feb 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova added Feature:ObsHosts Hosts feature within Observability needs-refinement A reason and acceptance criteria need to be defined for this issue labels Feb 10, 2023
@jennypavlova jennypavlova mentioned this issue Feb 13, 2023
Closed
@crespocarlos crespocarlos mentioned this issue Feb 24, 2023
Closed
@jennypavlova jennypavlova removed needs design needs-refinement A reason and acceptance criteria need to be defined for this issue labels Feb 28, 2023
@jennypavlova jennypavlova mentioned this issue Mar 8, 2023
Merged
jennypavlova added a commit that referenced this issue Mar 23, 2023
@jennypavlova @kibanamachine @tonyghiani
[Infrastructure UI] Show metadata for a single host on the host UI (#…
6591aa9 
…152956)

Closes [#150893](#150893)
## Summary
This PR adds a flyout with single host metadata with an option to
open/close it with a click on an expand/minimize icon in the table.

⚠️ This PR doesn't include metadata filtering/actions, or processes tab
inside flyout (they will be added in follow-up issues). For now, the
metadata will be displayed and no actions will be available.
This PR will unblock
[#151010](#151010),
[#150907](#150907) and
[#150985](#150985)

## Testing
- Open the hosts view and click on the expand icon for a single host in
the table
  
<img width="1464" alt="image"
src="https://user-images.githubusercontent.com/14139027/224077010-71aece78-40d1-4a3a-90a6-8e699001b37a.png">

- The flyout should be visible with a preselected metadata tab
containing
  - Host name as the flyout title
  - Metadata in a table view with field and value columns
  
<img width="1807" alt="image"
src="https://user-images.githubusercontent.com/14139027/224048634-cd49aa0f-f1a5-4442-9fd0-f16cd4cb84da.png">
- The flyout can be closed using the close icon and the minimize icon or
can show a different host when another host is expanded
<img width="1727" alt="image"
src="https://user-images.githubusercontent.com/14139027/224084969-daa525c5-4ec4-4504-b072-4711db63fe18.png">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Marco Antonio Ghiani <[email protected]>
This was referenced Mar 23, 2023
Closed
Merged
jennypavlova added a commit that referenced this issue Mar 27, 2023
@jennypavlova
[Infrastructure UI] Flyout metadata tests (#153683)
d06d2a3 
## Summary

Related to #150893

This PR adds tests for the flyout feature. Most of the changes are
adding test ids and helpers and the actual tests you can see in
[metadata.test.tsx](https://github.com/elastic/kibana/pull/153581/files#diff-c7a7e518f3cd536c1f63e64dfce04673790b7c4b80f78a60a6934dd14bbf402b)
and [hosts view functional
test](https://github.com/elastic/kibana/pull/153581/files#diff-cdf2ef63d7f0db051d569b09fbd2ba39eb852d3d75bf3b29d85e57de2da3af35R178)

### Functional Test 
Added a check for open/close of the flyout and metadata tab title
visibility - this can be expanded when the filtering functionality is
added

### Component Test
As we have many cases based on the metadata response I added a separate
test for the `metadata` component. Usually, we don't have this approach
but some cases like the error/no data case are hard to cover only with a
functional test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infrastructure UI] Show metadata for a single host on the host UI jennypavlova/kibana
4 participants
@jennypavlova @elasticmachine @roshan-elastic @kkurstak