Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infrastructure UI] Hosts View: Add links to APM and Uptime for a single host #150985

Closed
jennypavlova opened this issue Feb 13, 2023 · 6 comments · Fixed by #154269
Closed

[Infrastructure UI] Hosts View: Add links to APM and Uptime for a single host #150985

jennypavlova opened this issue Feb 13, 2023 · 6 comments · Fixed by #154269
Assignees
@jennypavlova
Labels
beta Required for a feature to move to beta Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Feb 13, 2023 •
edited
Loading

📓 Summary

Important information about a host for the SREs is how many and which services are running on the host. As we already have another issue showing APM-related data the scope of this issue will be to show the user a link navigating to APM services filtered by the selected host. We should navigate to Example link for example if the selected host is gke-edge-lite-oblt-edge-lite-oblt-poo-ac0838be-glnv:
image

[TBD] Do we want to show different links to the services and to the traces APM pages and which parameters do we want to use (enable comparison, custom time range, etc.)?
We show only one link navigating to services

🎨 Design

Figma

👨‍💻 Implementation hints

  • The link should be similar to the one we have in inventory with the difference that it should navigate to Services instead of Traces. In case we decide to have 2 different links (for traces and for services) we can reuse the inventory logic (single host flyout) for the traces link.

✔️ Acceptance criteria

  • The services link should navigate the user to the APM services with all required query parameters:
    • filter by hostname
    • time range
  • If APM is not enabled the user will be navigated to the services again and see the APM welcome page
  • Uptime link should be added to the flyout (same as Inventory)
@jennypavlova jennypavlova added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:ObsHosts Hosts feature within Observability labels Feb 13, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@jennypavlova jennypavlova added needs-refinement A reason and acceptance criteria need to be defined for this issue needs design labels Feb 13, 2023
@jennypavlova jennypavlova removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Feb 28, 2023
@tonyghiani
Copy link
Contributor

@jennypavlova What about adding the link in the table as a possible action for each specific host?
This could make it easier to access the host's APM without the need to create a custom filter for the host of interest.
Also, in case we want to access APM with a wider selection, there could be a more generic CTA that redirects to APM with all the query parameters. Wdyt?

@jennypavlova
Copy link
Member Author

Hi @tonyghiani we want to have a similar experience to the inventory single host view but have the links on top and not as part of the tabs as you can see in the design (there is also the Uptime link so it's not a single APM link). If we have the links in the table it will take some space and probably we will extend the table with more values in the future.
Also after the user opens the flyout he will find more information about the host (metadata, processes, etc) before going to the APM.
I think the table actions are expected to be related to the table and manipulating the values there If we add table actions it won't be clear to the user that the link leads to APM before he expands the actions menu (if we use the drop-down or link icon):
image
image

This could make it easier to access the host's APM without the need to create a custom filter for the host of interest.

Also, you don't need a filter to see the flyout it opens when you click an expand icon next to it or I am missing something here?

@tonyghiani
Copy link
Contributor

Hi @tonyghiani we want to have a similar experience to the inventory single host view but have the links on top and not as part of the tabs as you can see in the design (there is also the Uptime link so it's not a single APM link). If we have the links in the table it will take some space and probably we will extend the table with more values in the future. Also after the user opens the flyout he will find more information about the host (metadata, processes, etc) before going to the APM. I think the table actions are expected to be related to the table and manipulating the values there If we add table actions it won't be clear to the user that the link leads to APM before he expands the actions menu (if we use the drop-down or link icon): image image

This could make it easier to access the host's APM without the need to create a custom filter for the host of interest.

Also, you don't need a filter to see the flyout it opens when you click an expand icon next to it or I am missing something here?

It makes sense, thanks for the explanation! Yep, having it in the flyout is the best option 👌

@jennypavlova jennypavlova mentioned this issue Mar 9, 2023
Merged
@jennypavlova jennypavlova changed the title [Infrastructure UI] Hosts View: Add links to APM for a single host [Infrastructure UI] Hosts View: Add links to APM and Uptime for a single host Mar 9, 2023
@roshan-elastic roshan-elastic added beta Required for a feature to move to beta v8.8.0 labels Mar 13, 2023
jennypavlova added a commit that referenced this issue Mar 23, 2023
@jennypavlova @kibanamachine @tonyghiani
[Infrastructure UI] Show metadata for a single host on the host UI (#…
6591aa9 
…152956)

Closes [#150893](#150893)
## Summary
This PR adds a flyout with single host metadata with an option to
open/close it with a click on an expand/minimize icon in the table.

⚠️ This PR doesn't include metadata filtering/actions, or processes tab
inside flyout (they will be added in follow-up issues). For now, the
metadata will be displayed and no actions will be available.
This PR will unblock
[#151010](#151010),
[#150907](#150907) and
[#150985](#150985)

## Testing
- Open the hosts view and click on the expand icon for a single host in
the table
  
<img width="1464" alt="image"
src="https://user-images.githubusercontent.com/14139027/224077010-71aece78-40d1-4a3a-90a6-8e699001b37a.png">

- The flyout should be visible with a preselected metadata tab
containing
  - Host name as the flyout title
  - Metadata in a table view with field and value columns
  
<img width="1807" alt="image"
src="https://user-images.githubusercontent.com/14139027/224048634-cd49aa0f-f1a5-4442-9fd0-f16cd4cb84da.png">
- The flyout can be closed using the close icon and the minimize icon or
can show a different host when another host is expanded
<img width="1727" alt="image"
src="https://user-images.githubusercontent.com/14139027/224084969-daa525c5-4ec4-4504-b072-4711db63fe18.png">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Marco Antonio Ghiani <[email protected]>
@jennypavlova jennypavlova self-assigned this Apr 3, 2023
@jennypavlova jennypavlova mentioned this issue Apr 3, 2023
Merged
@jennypavlova
Copy link
Member Author

jennypavlova commented Apr 5, 2023 •
edited
Loading

@roshan-elastic should we use traces with the updated link name APM traces or do we want to navigate to APM services? The APM link in inventory navigates to traces, I can't remember if we decided to keep it the same at the end.
Links in the design:
image

@roshan-elastic
Copy link

Hey @jennypavlova - can we link to the services (and call it "APM Services")?

jennypavlova added a commit that referenced this issue Apr 6, 2023
@jennypavlova @crespocarlos
[Infrastructure UI] Hosts view: Add links to apm and uptime for a sin…
8c2ff54 
…gle host (#154269)

Closes #150985 

## Summary

This PR adds links to APM Traces and Uptime.
<img width="1909" alt="image"
src="https://user-images.githubusercontent.com/14139027/229580612-a3d0c03a-4f68-4b09-b333-ffa79c8454e6.png">

# Testing
1. Open Hosts view 
2. Click on the button to open the flyout for a single host
- Click on the APM traces link and verify the query parameters are
correct
- Click on the uptime link and verify the query parameters are correct
   


https://user-images.githubusercontent.com/14139027/229581672-3c50ea55-e834-4431-aac6-3ed3ff9f96cc.mov

---------

Co-authored-by: Carlos Crespo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
beta Required for a feature to move to beta Feature:Metrics UI Metrics UI feature Feature:ObsHosts Hosts feature within Observability Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infrastructure UI] Hosts view: Add links to apm and uptime for a single host jennypavlova/kibana
6 participants
@miltonhultgren @jennypavlova @elasticmachine @tonyghiani @roshan-elastic @kkurstak