[Infrastructure UI] Flyout metadata tests #153581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
jennypavlova
commented
Mar 23, 2023
| @@ -26,7 +26,7 @@ export interface TabProps { | |||
| node: HostNodeRow; | |||
| } | |||
|
|
|||
| const Metadata = ({ node, currentTimeRange }: TabProps) => { | |||
| export const Metadata = ({ node, currentTimeRange }: TabProps) => { | |||
There was a problem hiding this comment.
Exported for testing purposes
| @@ -0,0 +1,40 @@ | |||
| /* | |||
There was a problem hiding this comment.
I added this wrapper to have it shared for all components and make it easier to test the components without wrapping them in each test - we can expand it with core services mocks if needed for other tests.
| jest.mock('../../../../../../containers/metrics_source'); | ||
| jest.mock('../../../../metric_detail/hooks/use_metadata'); | ||
|
|
||
| const metadataProps: TabProps = { |
There was a problem hiding this comment.
I keep the whole object to match the type restriction
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
jennypavlova
force-pushed
the
150893-flyout-metadata-tests
branch
from
1cb8a4d to
4a04953
Compare
💔 Build FailedFailed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Page load bundle
Saved Objects .kibana field count
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
miscellaneous assets size
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #150893
This PR adds tests for the flyout feature. Most of the changes are adding test ids and helpers and the actual tests you can see in metadata.test.tsx and hosts view functional test
Functional Test
Added a check for open/close of the flyout and metadata tab title visibility - this can be expanded when the filtering functionality is added
Component Test
As we have many cases based on the metadata response I added a separate test for the
metadatacomponent. Usually, we don't have this approach but some cases like the error/no data case are hard to cover only with a functional test.