Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts - dashboard sync colors should sync colors on dashboard by default #148557

Closed
kibanamachine opened this issue Jan 9, 2023 · 32 comments · Fixed by #150087, #152964, #160650, #172633 or #173582
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 9, 2023

A test failed on a tracked branch

Error: timed out waiting for endDate is set to Sep 23, 2015 @ 18:31:44.000 -- last error: Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="superDatePickerendDatePopoverButton"])
Wait timed out after 10027ms
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-2b82c0ecaf6622be/elastic/kibana-on-merge/kibana/node_modules/selenium-webdriver/lib/webdriver.js:907:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at onFailure (retry_for_success.ts:17:9)
    at retryForSuccess (retry_for_success.ts:59:13)
    at RetryService.try (retry.ts:31:12)
    at Proxy.clickByCssSelector (find.ts:407:5)
    at TestSubjects.click (test_subjects.ts:164:5)
    at time_picker.ts:147:7
    at runAttempt (retry_for_success.ts:29:15)
    at retryForSuccess (retry_for_success.ts:68:21)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at TimePickerPageObject.setAbsoluteRange (time_picker.ts:146:5)
    at Object.goToTimeRange (lens_page.ts:61:7)
    at Context.<anonymous> (sync_colors.ts:58:7)
    at Object.apply (wrap_function.js:73:16)
    at onFailure (retry_for_truthy.ts:39:13)
    at retryForSuccess (retry_for_success.ts:59:13)
    at retryForTruthy (retry_for_truthy.ts:27:3)
    at RetryService.waitFor (retry.ts:59:5)
    at TimePickerPageObject.setAbsoluteRange (time_picker.ts:146:5)
    at Object.goToTimeRange (lens_page.ts:61:7)
    at Context.<anonymous> (sync_colors.ts:58:7)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 9, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 9, 2023
@mistic mistic added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jan 9, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 9, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@nreese
Copy link
Contributor

nreese commented Feb 1, 2023

Failure occurs because click on Create visualization button in Dashboard fails to open Lens.

Notice in the failure logs that DashboardAddPanel.clickAddNewPanelButton is called. Then lensPage.goToTimeRange() yet if you look at the captured screen shot, lens never opened and dashboard is still open.

[00:00:28]         │ debg DashboardAddPanel.clickAddNewPanelButton
[00:00:28]         │ debg TestSubjects.click(dashboardAddNewPanelButton)
[00:00:28]         │ debg Find.clickByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:00:28]         │ debg Find.findByCssSelector('[data-test-subj="dashboardAddNewPanelButton"]') with timeout=10000
[00:00:29]         │ debg ... sleep(500) start
[00:00:30]         │ debg ... sleep(500) end
[00:00:30]         │ debg isGlobalLoadingIndicatorVisible
[00:00:30]         │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:30]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:31]         │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:00:32]         │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:32]         │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:32]         │ debg lensPage.goToTimeRange()
[00:00:32]         │ debg TestSubjects.exists(noDataPopoverDismissButton)
[00:00:32]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="noDataPopoverDismissButton"]') with timeout=100
[00:00:32]         │ debg --- retry.tryForTime error: [data-test-subj="noDataPopoverDismissButton"] is not displayed
[00:00:32]         │ debg Setting absolute range to Sep 19, 2015 @ 06:31:44.000 to Sep 23, 2015 @ 18:31:44.000
[00:00:32]         │ debg TestSubjects.exists(superDatePickerToggleQuickMenuButton)
[00:00:32]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerToggleQuickMenuButton"]') with timeout=20000
[00:00:32]         │ debg TestSubjects.exists(superDatePickerShowDatesButton)
[00:00:32]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerShowDatesButton"]') with timeout=50
[00:00:33]         │ debg --- retry.tryForTime error: [data-test-subj="superDatePickerShowDatesButton"] is not displayed
[00:00:33]         │ debg TestSubjects.exists(superDatePickerstartDatePopoverButton)
[00:00:33]         │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="superDatePickerstartDatePopoverButton"]') with timeout=1000

Notice in failure screen shot how the application is still in Dashboard.
dashboard sync colors should sync colors on dashboard by default-1457fa9bb83764292843bfe83aefcb96fdf4557332722b10754da841d5e7b5fe

nreese added a commit that referenced this issue Feb 1, 2023
…ional/apps/dashboard/group2/sync_colors·ts (#150087)

Fixes #148557 and
#148558

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1854

See
#148557 (comment)
for explanation of failure. PR resolves flakiness by adding retry in
clickCreateNewLink, ensuring clickCreateNewLink opens lens or else
retries.
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Feb 6, 2023
…ional/apps/dashboard/group2/sync_colors·ts (elastic#150087)

Fixes elastic#148557 and
elastic#148558

Flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1854

See
elastic#148557 (comment)
for explanation of failure. PR resolves flakiness by adding retry in
clickCreateNewLink, ensuring clickCreateNewLink opens lens or else
retries.
@kibanamachine kibanamachine reopened this Mar 8, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@nreese nreese self-assigned this Mar 8, 2023
@Heenawter Heenawter added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Mar 8, 2023
nreese added a commit that referenced this issue Mar 8, 2023
…k/test/functional/apps/dashboard/group2/sync_colors·ts (#152964)

Fixes #148557

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000

Image from failed test shows query autosuggest menu is blocking "create
visualize" button. PR fixes issue be pressing escape to close
autosuggest menu if its open.


![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)
bmorelli25 pushed a commit to bmorelli25/kibana that referenced this issue Mar 10, 2023
…k/test/functional/apps/dashboard/group2/sync_colors·ts (elastic#152964)

Fixes elastic#148557

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000

Image from failed test shows query autosuggest menu is blocking "create
visualize" button. PR fixes issue be pressing escape to close
autosuggest menu if its open.


![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)
@kibanamachine kibanamachine reopened this Mar 31, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.7

nickpeihl pushed a commit to nickpeihl/kibana that referenced this issue Mar 31, 2023
…k/test/functional/apps/dashboard/group2/sync_colors·ts (elastic#152964)

Fixes elastic#148557

flaky test runner
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000

Image from failed test shows query autosuggest menu is blocking "create
visualize" button. PR fixes issue be pressing escape to close
autosuggest menu if its open.

![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)

(cherry picked from commit edf3a83)

# Conflicts:
#	test/functional/services/dashboard/add_panel.ts
nickpeihl added a commit that referenced this issue Mar 31, 2023
….x-pack/test/functional/apps/dashboard/group2/sync_colors·ts (#152964) (#154194)

Fixes #148557

# Backport

This will backport the following commits from `main` to `8.7`:
- [[dashboard] fix Failing test: Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts
(#152964)](#152964)

<!--- Backport version: 8.9.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-03-08T21:54:05Z","message":"[dashboard]
fix Failing test: Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts
(#152964)\n\nFixes
https://github.com/elastic/kibana/issues/148557\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000\r\n\r\nImage
from failed test shows query autosuggest menu is blocking
\"create\r\nvisualize\" button. PR fixes issue be pressing escape to
close\r\nautosuggest menu if its
open.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)","sha":"edf3a8362488b191cca75500371f0bad5c8e86cc","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","Team:Presentation","loe:hours","release_note:skip","impact:high","backport:skip","v8.8.0"],"number":152964,"url":"https://github.com/elastic/kibana/pull/152964","mergeCommit":{"message":"[dashboard]
fix Failing test: Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts
(#152964)\n\nFixes
https://github.com/elastic/kibana/issues/148557\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000\r\n\r\nImage
from failed test shows query autosuggest menu is blocking
\"create\r\nvisualize\" button. PR fixes issue be pressing escape to
close\r\nautosuggest menu if its
open.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)","sha":"edf3a8362488b191cca75500371f0bad5c8e86cc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/152964","number":152964,"mergeCommit":{"message":"[dashboard]
fix Failing test: Chrome X-Pack UI Functional
Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts
(#152964)\n\nFixes
https://github.com/elastic/kibana/issues/148557\r\n\r\nflaky test
runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2000\r\n\r\nImage
from failed test shows query autosuggest menu is blocking
\"create\r\nvisualize\" button. PR fixes issue be pressing escape to
close\r\nautosuggest menu if its
open.\r\n\r\n\r\n![image](https://user-images.githubusercontent.com/373691/223846637-3e595803-e39d-4392-a84c-69a455f70a42.png)","sha":"edf3a8362488b191cca75500371f0bad5c8e86cc"}}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <[email protected]>
@nickpeihl
Copy link
Member

Fixed by #154194

@Heenawter
Copy link
Contributor

Looks like a CI environment issue - the dashboard app completely failed to load:

image

Closing for now.

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2023
@kibanamachine kibanamachine reopened this Dec 5, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@Heenawter
Copy link
Contributor

Heenawter commented Dec 5, 2023

The tooltip showing an empty dataset is getting in the way of our click - we'll want to disable or dismiss this.

image

@Heenawter Heenawter removed their assignment Dec 5, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@Heenawter Heenawter self-assigned this Dec 5, 2023
@Heenawter
Copy link
Contributor

Closed by #172633

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@mistic
Copy link
Member

mistic commented Dec 14, 2023

Skipped.

main: 65016be

@Heenawter Heenawter assigned Heenawter and unassigned Heenawter Dec 18, 2023
Heenawter added a commit that referenced this issue Dec 20, 2023
Closes #148557

## Summary

[Ran the
FTR](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4636)
on the skipped test suite and it passed 100 times... Really unclear on
why it keeps failing, especially after
#172633. For now, since I can't
get it to fail locally or with the FTR, I'm going to unskip. If it
starts to fail on `main` again, we could loop in the Vis team to help
(since it's the timepicker in the Lens app that is misbehaving) - but
hopefully the previous failure was a fluke and that won't be necessary🤞

### Checklist

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
([Link](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4636))
![Screenshot 2023-12-20 at 7 47
58 AM](https://github.com/elastic/kibana/assets/8698078/523e715a-a347-4c82-955c-b18cabe53566)


### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment