[Content management] fix table list flashes table interface when empty #160650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
force-pushed
the
listing_empty_state
branch
from
e5ff383 to
6beb01e
Compare
|
@elasticmachine merge upstream |
nreese
added
v8.9.0
v8.10.0
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
nreese
added
the
release_note:skip
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 29, 2023
elastic#160650) Closes elastic#159507 Closes elastic#148557 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508 ### Test instructions * Install sample web logs data set * Delete dashboard that ships with sample data set * switch to another app, like visualize * Use debugger tools to throttle network connection to "slow 3g" * Open dashboard application again * Verify empty table view is never displayed and there is no flickering between views. --------- Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9f73f94)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 29, 2023
…n empty (#160650) (#160893) # Backport This will backport the following commits from `main` to `8.9`: - [[Content management] fix table list flashes table interface when empty (#160650)](#160650) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-06-29T13:55:16Z","message":"[Content management] fix table list flashes table interface when empty (#160650)\n\nCloses https://github.com/elastic/kibana/issues/159507\r\nCloses https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n### Test instructions\r\n* Install sample web logs data set\r\n* Delete dashboard that ships with sample data set\r\n* switch to another app, like visualize\r\n* Use debugger tools to throttle network connection to \"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty table view is never displayed and there is no flickering\r\nbetween views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","Team:SharedUX","v8.9.0","v8.10.0"],"number":160650,"url":"https://github.com/elastic/kibana/pull/160650","mergeCommit":{"message":"[Content management] fix table list flashes table interface when empty (#160650)\n\nCloses https://github.com/elastic/kibana/issues/159507\r\nCloses https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n### Test instructions\r\n* Install sample web logs data set\r\n* Delete dashboard that ships with sample data set\r\n* switch to another app, like visualize\r\n* Use debugger tools to throttle network connection to \"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty table view is never displayed and there is no flickering\r\nbetween views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796"}},"sourceBranch":"main","suggestedTargetBranches":["8.9"],"targetPullRequestStates":[{"branch":"8.9","label":"v8.9.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160650","number":160650,"mergeCommit":{"message":"[Content management] fix table list flashes table interface when empty (#160650)\n\nCloses https://github.com/elastic/kibana/issues/159507\r\nCloses https://github.com/elastic/kibana/issues/148557\r\n\r\nFlaky test runner\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508\r\n\r\n### Test instructions\r\n* Install sample web logs data set\r\n* Delete dashboard that ships with sample data set\r\n* switch to another app, like visualize\r\n* Use debugger tools to throttle network connection to \"slow 3g\"\r\n* Open dashboard application again\r\n* Verify empty table view is never displayed and there is no flickering\r\nbetween views.\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"9f73f9479c1ff77fbada8305e618931b57d65796"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159507
Closes #148557
Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/2508
Test instructions