fix Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group2/sync_colors·ts #150087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional/apps/dashboard/group2/sync_colors·ts
nreese
commented
Feb 1, 2023
| @@ -25,9 +25,14 @@ export class DashboardAddPanelService extends FtrService { | |||
|
|
|||
| async clickCreateNewLink() { | |||
| this.log.debug('DashboardAddPanel.clickAddNewPanelButton'); | |||
| await this.testSubjects.click('dashboardAddNewPanelButton'); | |||
| // Give some time for the animation to complete | |||
| await this.common.sleep(500); | |||
There was a problem hiding this comment.
Button used to open a modal, but that is no longer true so there is no animation to wait for.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Feb 1, 2023
kibanamachine
added
v8.7.0
backport:skip
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
…ional/apps/dashboard/group2/sync_colors·ts (elastic#150087) Fixes elastic#148557 and elastic#148558 Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1854 See elastic#148557 (comment) for explanation of failure. PR resolves flakiness by adding retry in clickCreateNewLink, ensuring clickCreateNewLink opens lens or else retries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #148557 and #148558
Flaky test runner https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1854
See #148557 (comment) for explanation of failure. PR resolves flakiness by adding retry in clickCreateNewLink, ensuring clickCreateNewLink opens lens or else retries.