-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the shareable alerts table in Observability Alerts page #134887
Comments
During checking the sharable alert table and the current one, I found some differences as follows:
Also, I noticed we have an
|
Hi @maryam-saeidi , I can answer two of them:
About the rest, is there any that would be blocking the integration? What would have higher priority? |
@jcger |
It's looks like something that is prepared to work but doesn't. I've seen that in o11y the t_grid is set with a default sort prop here and that we load it from from the registry here so in theory you would be ready to go by adding the same sort prop you set to t_grid but when registering here. I'll keep it mind when working on my current task so it doesn't break/works once I'm done |
@jcger Works like a charm! 👍🏻 |
Update Found this ticket about it: #134892 |
Dependencies
Related improvements
AlertsTable
component #138894AlertsTable
#138895These improvements will be fixed in #137988
📝 Summary
In order to integrate the new alerts table, it needs to support the same functionalities with the previous alerts table implementation. Once the above dependent issues are completed (search, timerange and status filtering, empty state & bulk actions) we can then move on with the integration of the new alerts table in the Alerts page.
The text was updated successfully, but these errors were encountered: