Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the shareable alerts table in Observability Alerts page #134887

Closed
5 of 6 tasks
Tracked by #132816 ...
mgiota opened this issue Jun 22, 2022 · 7 comments · Fixed by #139544
Closed
5 of 6 tasks
Tracked by #132816 ...

Integrate the shareable alerts table in Observability Alerts page #134887

mgiota opened this issue Jun 22, 2022 · 7 comments · Fixed by #139544
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0

Comments

@mgiota
Copy link
Contributor

mgiota commented Jun 22, 2022

Dependencies

Related improvements

These improvements will be fixed in #137988

📝 Summary

In order to integrate the new alerts table, it needs to support the same functionalities with the previous alerts table implementation. Once the above dependent issues are completed (search, timerange and status filtering, empty state & bulk actions) we can then move on with the integration of the new alerts table in the Alerts page.

@mgiota mgiota changed the title Integrate the shareable alerts table in Obervability Alerts page [Actionable Observability] Integrate the shareable alerts table in Obervability Alerts page Jun 22, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 22, 2022
@mgiota mgiota added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Jun 22, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 22, 2022
@emma-raffenne emma-raffenne changed the title [Actionable Observability] Integrate the shareable alerts table in Obervability Alerts page Integrate the shareable alerts table in Observability Alerts page Jun 24, 2022
@maryam-saeidi maryam-saeidi self-assigned this Aug 15, 2022
@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 17, 2022

During checking the sharable alert table and the current one, I found some differences as follows:

image

  1. @XavierM Regarding the filter previously we had the Last update selected by default, is this sth that we want to change in the new table? @jcger showed me the configuration.
  2. [Actionable Observability] Show count of alerts in the shared AlertsTable component #138894
  3. @XavierM @simianhacker do we have a setting to show or hide Fields? Or is it related to [Observability][RAC] Users need view_index_metadata index privilege to view fields on Alerts page #133060? since I am using the default elastic user, I think it should not be related to permissions but I am not sure.
  4. [Actionable Observability] Align duration values right in the cells for better legibility of numbered content in shared AlertsTable #138895

Also, I noticed we have an inspect option in the current implementation:

Inspect button Inspect modal
image image
  1. @XavierM Do we have a plan to have it in the shared alert table?
    Answer from @XavierM: It was decided that this component will not be implemented in the new shareable component since it is not used often. (If I am not mistaken, it was discussed with @katrin-freihofner)

@jcger
Copy link
Contributor

jcger commented Aug 17, 2022

Hi @maryam-saeidi , I can answer two of them:

  1. It's currently in progress, as it fixes more than one issue we centralised everything here [RAM] [META] Dynamic field selection in Alerts Table #137988
  2. Will be fixed once 3 is done

About the rest, is there any that would be blocking the integration? What would have higher priority?

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 17, 2022

@jcger
1- Do you know what is the default sort for the shared component? If the default sort is based on the last update by default, probably it has less priority.
2- It does not seem to me like a blocker, @formgeist @vinaychandrasekhar what do you think about its priority?
5- Not sure about the priority, @vinaychandrasekhar what is your thought about it?

@jcger
Copy link
Contributor

jcger commented Aug 17, 2022

1- Do you know what is the default sort for the shared component? If the default sort is based on the last update by default, probably it has less priority.

It's looks like something that is prepared to work but doesn't. I've seen that in o11y the t_grid is set with a default sort prop here and that we load it from from the registry here so in theory you would be ready to go by adding the same sort prop you set to t_grid but when registering here. I'll keep it mind when working on my current task so it doesn't break/works once I'm done

@maryam-saeidi

@maryam-saeidi
Copy link
Member

@jcger Works like a charm! 👍🏻

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Aug 18, 2022

  1. Refresh capability is also missing.

Update

Found this ticket about it: #134892

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Sep 1, 2022

@jcger @XavierM Regarding item 2 here, showing the number of alerts, do you have a ticket?

Update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.5.0
Projects
None yet
4 participants