[Actionable Observability] Integrate the shareable alerts table in the Observability Alerts page #139544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/oblt-deploy |
|
/oblt-deploy |
maryam-saeidi
added
release_note:enhancement
chore
release_note:skip
maryam-saeidi
commented
Aug 30, 2022
| @@ -54,9 +54,6 @@ export function AlertsSearchBar({ | |||
| timeHistory={timeHistory} | |||
| dateRangeFrom={rangeFrom} | |||
| dateRangeTo={rangeTo} | |||
| onRefresh={({ dateRange }) => { | |||
There was a problem hiding this comment.
onRefresh was not working as expected, when clicking on the refresh button, onQuerySubmit was called, I assume it is related to how this SearchBar is configured.
Let me know if someone has an idea about it.
maryam-saeidi
commented
Aug 30, 2022
| import { ALERT_STATUS } from '@kbn/rule-data-utils'; | ||
|
|
||
| export const ALERTS_PAGE_ID = 'alerts-o11y'; | ||
| export const ALERTS_TABLE_ID = 'xpack.observability.alerts.table'; |
There was a problem hiding this comment.
I just added this table id, the rest are the same as before.
kdelemme
reviewed
Aug 31, 2022
| import { ParsedTechnicalFields } from '@kbn/rule-registry-plugin/common/parse_technical_fields'; | ||
| import { ParsedExperimentalFields } from '@kbn/rule-registry-plugin/common/parse_experimental_fields'; | ||
| import { Storage } from '@kbn/kibana-utils-plugin/public'; | ||
| import { AlertConsumers } from '@kbn/rule-data-utils'; |
There was a problem hiding this comment.
nit: merge AlertStatus with AlertConsumers import
kdelemme
approved these changes
Aug 31, 2022
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
added
the
Team: Actionable Observability - DEPRECATED
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
…e Observability Alerts page (elastic#139544) * Use TIMESTAMP as default field for sort in shared alert table * Use new ResponseOps shareable alerts table in Observability Alerts page * Bring back CasesContext and fix and test issues * Fix pagination test * Correct sort order and fix alerts functional test * Fix column css selector * Add refresh and extract creating esQuery in a separate helper * Fix file names * Fix import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134887
Fixes #139566
Summary
This PR integrates the shareable alerts table to the observability alerts page.
Important: Refresh functionality is not implemented yet, we need to wait for #134892 before merging.--> Merged!Checklist