Update calculatePopoverPosition to seek the position with the largest amount of visible surface area of the popover. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
calculate-popover-position
branch
from
1582230
to
48e7f74
Compare
… amount of visible surface area of the popover.
cjcenizal
force-pushed
the
calculate-popover-position
branch
2 times, most recently
from
90a6de5
to
263dd95
Compare
- Fix mistakes with calculating height and width differences. - Remove calculatePopoverStyles.
snide
approved these changes
Mar 21, 2018
nreese
reviewed
Mar 21, 2018
| /** | ||
| * Determine the best position for a popup that avoids clipping by the window view port. | ||
| * Determine the best position for a popover that avoids clipping by the window view port. |
There was a problem hiding this comment.
Looks like this comment get detached from the function it describes.
cjcenizal
force-pushed
the
calculate-popover-position
branch
from
c1cc5d5
to
b72356f
Compare
|
Woo! Thanks @cjcenizal! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #545
The original logic for this method found the position with the least amount of overflow in a single direction, but for the optimal UX it needs to consider how much total surface area of the popover is being clipped, and choose the position where as much of the popover is visible as possible.