Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip popover screen edge avoidance #545

Closed
arkwright opened this issue Mar 20, 2018 · 3 comments
Closed

Tooltip popover screen edge avoidance #545

arkwright opened this issue Mar 20, 2018 · 3 comments
Assignees

Comments

@arkwright
Copy link
Contributor

screen shot 2018-03-20 at 2 08 08 pm

Tooltip popovers (EuiIconTip shown) can extend past the edge of the screen in some scenarios. Ideally the tooltip would dynamically adjust its position to avoid rendering content off screen.

@snide
Copy link
Contributor

snide commented Mar 20, 2018

@arkwright it should do this based on https://github.com/elastic/eui/blob/master/src/services/popover/popover_calculate_position.js. If you can provide it, I'd love to see what scenario replicates this.

I have seen instances where the listening is a little laggy though.

@arkwright
Copy link
Contributor Author

screen shot 2018-03-20 at 4 24 00 pm

As it turns out, this is reproducible in both FF and Chrome on the tooltip documentation page. I just resized my window to mobile dimensions.

https://elastic.github.io/eui/#/display/tooltip

@snide
Copy link
Contributor

snide commented Mar 20, 2018

@cjcenizal do you mind checking this out? I see that it's working for EuiToolTip but not these EuiIconTip ones. Haven't peeped the code very closely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants