Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calculatePopoverPosition to seek the position with the largest amount of visible surface area of the popover. #550

Merged
merged 6 commits into from
Mar 21, 2018
Merged

Update calculatePopoverPosition to seek the position with the largest amount of visible surface area of the popover. #550

merged 6 commits into from
Mar 21, 2018

Commits on Mar 21, 2018

  1. Update calculatePopoverPosition to seek the position with the largest… 

    … amount of visible surface area of the popover.
    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    263dd95 View commit details
    Browse the repository at this point in the history

  2. Return position data from calculatePopoverPosition. 

    - Fix mistakes with calculating height and width differences.
- Remove calculatePopoverStyles.
    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    c376e4b View commit details
    Browse the repository at this point in the history

  3. Put comment back where it belongs. Fix EuiIconTip example.

    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    36a890c View commit details
    Browse the repository at this point in the history

  4. Rename popver_calculate_position to calculate_popover_position.

    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    2de8f3e View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.

    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    18f5657 View commit details
    Browse the repository at this point in the history

  6. Clarify calculatePopoverPosition comments and use array reduce() method.

    @cjcenizal
    cjcenizal committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    b72356f View commit details
    Browse the repository at this point in the history