Added euiTextBreakWord() to EuiToast header and fixed .eui-textBreakAll on Firefox
#2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
changed the title
euiTextBreakWord() to EuiToast header and fix .eui-textBreakAll on FirefoxeuiTextBreakWord() to EuiToast header and fixed .eui-textBreakAll on Firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1021 and elastic/kibana#48984
Since
euiTextBreakWord()is an elegant solution for only forcing line breaks within words (if necessary) it provides an easy solution.Before
After
Fixes #2288
Added @legrego 's solutions of
overflow-wrap: break-wordto.eui-textBreakAll.Before
After
Checklist
[ ] Checked in dark mode[ ] Checked in mobile[ ] Props have proper autodocs[ ] Added documentation examplesI will be reverting the doc change before merge[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes