Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added euiTextBreakWord() to EuiToast header and fixed .eui-textBreakAll on Firefox #2549

Merged
merged 3 commits into from
Nov 21, 2019
Merged

Added euiTextBreakWord() to EuiToast header and fixed .eui-textBreakAll on Firefox #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
408e3e6
Added `euiTextBreakWord()` to EuiToast header
Nov 20, 2019
94d65ae
Add `overflow-wrap: break-word` to `.eui-textBreakAll`
Nov 20, 2019
0c5e006
cl
Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
**Bug fixes**

- `EuiSwitch` now passes `name` attribute into underlying `button` ([#2533](https://github.com/elastic/eui/pull/2533))
- Added `euiTextBreakWord()` to `EuiToast` header ([#2549](https://github.com/elastic/eui/pull/2549))
- Fixed `.eui-textBreakAll` on Firefox ([#2549](https://github.com/elastic/eui/pull/2549))

## [`16.0.0`](https://github.com/elastic/eui/tree/v16.0.0)

Expand Down
2 changes: 1 addition & 1 deletion src-docs/src/views/guidelines/toasts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ and space to read it properly. Alternatively just link to a full page.
<EuiToast
color="success"
style={{ maxWidth: 300 }}
title="Dashboard 'My_dashboard' was saved"
title="Dashboard 'My_dashboard_with_a_very_long_name' was saved"
/>
</GuideRuleExample>

Expand Down
3 changes: 2 additions & 1 deletion src-docs/src/views/utility_classes/utility_classes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ export default () => (

<div style={wrappingExampleStyle} className="eui-textBreakAll">
<EuiCode>.eui-textBreakAll</EuiCode> will break up anything. It is useful
for long urls like {longLink}.
for long urls like {longLink}{' '}
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------.
</div>

<EuiSpacer />
Expand Down
1 change: 1 addition & 0 deletions src/components/toast/_toast.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ $toastTypes: (

.euiToastHeader__title {
@include euiTitle('xs');
@include euiTextBreakWord;
font-weight: $euiFontWeightLight;
}

Expand Down
1 change: 1 addition & 0 deletions src/global_styling/utility/_utility.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
}

.eui-textBreakAll {
overflow-wrap: break-word !important; // Fixes FF when dashes are involved #2288
word-break: break-all !important;
}

Expand Down