Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast header overflows the toast element #1021

Closed
cjcenizal opened this issue Jul 17, 2018 · 2 comments · Fixed by #2549
Closed

Toast header overflows the toast element #1021

cjcenizal opened this issue Jul 17, 2018 · 2 comments · Fixed by #2549
Labels

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Jul 17, 2018

v1.1.0

image

@cjcenizal cjcenizal added the bug label Jul 17, 2018
@cchaos
Copy link
Contributor

cchaos commented Jul 17, 2018

@cjcenizal You'll want to add the utility class of .eui-textBreakAll to the title text to make sure it breaks in the middle of words.

Also, in this particular case, the title seems a bit long. It feels more like the first sentence is the title and the rest is the description. It'll help user's find the actual cause of the warning quicker. (2 cents)

@cjcenizal
Copy link
Contributor Author

Also, in this particular case, the title seems a bit long. It feels more like the first sentence is the title and the rest is the description. It'll help user's find the actual cause of the warning quicker. (2 cents)

I agree! This is what I ended up doing.

You'll want to add the utility class of .eui-textBreakAll to the title text to make sure it breaks in the middle of words.

Do you think we can add a prop to the toast, e.g. textBreak="all", to apply this class for us? I think the convenience would make sense for narrow components like toasts, where we can expect this to occur more often than for wider components. Manually-applied classes are tougher debug and tougher to maintain, so I think it would be nice for the DX to reserve them as a last resort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants