You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added aria-pressed attrs to filter buttons those have just two states: they are toggle indeed.
Don't to get lost in snapshot updates, have a look at the list of commits: I put code updates separately to snapshots updates between commits.
Part 2
Another component, Delay Render is coded, slightly similar to DelayHide component.
Existing solutions I found around use either promise fetching or deprecated componentWillMount,
since what we need here is exactly timing based delayed rendering.
It is so as Aria Live Regions is used by ScreenReader to detect changes and announce those changes.
So, there is at least a couple way to implement that: collect all new updates in textNode, every sorting update or clear it every time and fulfill with only one necessary update.
Also, following the 2nd approach it is suitable to use such a component for any delayed render.
PhilippBaranovskiy
changed the title
WIP: DRAFT: Temporal Content Switches in Table Search and Filter #749
WIP: Temporal Content Switches in Table Search and Filter #749
Apr 23, 2019
PhilippBaranovskiy
changed the title
WIP: Temporal Content Switches in Table Search and Filter #749
WIP: (Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
Apr 23, 2019
Thanks for this @rockfield! I'm going to hand off review to @chandlerprall and @thompsongl, as they're the maintainers of EUI and I'm low on bandwidth ATM.
@rockfield is this still a WIP or ready for a review? @thompsongl, sorry for the delay, -- Now this PR is ready for review.
Could you please have a look?
PhilippBaranovskiy
changed the title
WIP: (Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
(Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
May 6, 2019
PhilippBaranovskiy
changed the title
WIP: (Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
(Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
May 21, 2019
@thompsongl@maryia-lapata@chandlerprall @Avinar-24
This PR is ready for the final review. No other changes are going to happen.
Please, find some time to have a look.
PhilippBaranovskiy
changed the title
(Accessibility) (Delay Render) Temporal Content Switches in Table Search and Filter #749
(Accessibility) EuiDelayRender
May 31, 2019
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhilippBaranovskiy
changed the title
Related to #749
Related to elastic/kibana#28385
Summary
Part 1
I've added aria-pressed attrs to filter buttons those have just two states: they are toggle indeed.
Part 2
Another component, Delay Render is coded, slightly similar to DelayHide component.
Existing solutions I found around use either promise fetching or deprecated componentWillMount,
since what we need here is exactly timing based delayed rendering.
It is so as Aria Live Regions is used by ScreenReader to detect
changesand announce those changes.So, there is at least a couple way to implement that: collect all new updates in textNode, every sorting update or clear it every time and fulfill with only one necessary update.
Also, following the 2nd approach it is suitable to use such a component for any delayed render.