-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal Content Switches in Table Search and Filter #749
Comments
This would address elastic/kibana#20200. |
As I can see now, ScreenReader just says at the moment of focusing on search input that the future results will be filtered as the user types. I'm going to follow-up this issue as the filter button (see the screen below) needs to announce itself as well as changed results once the user toggled it. I guess it also relates to #1184. I would suggest that we/I should implement the on-live trigger for all that kind of cases where it needs to notify the user that something is changing on a page right now at the moment of they are typing. Such case already exists: @cjcenizal @snide @aphelionz @cchaos, |
@rockfield At first glance, the AdvancedSettingsVoiceAnnouncement component you shared looks fairly generic. It seems like you would be able to use this to address the accessibility problems you mentioned. What do you think? If so, then I suggest migrating it to EUI. My only concern is that built-in delay within the component. It seems potentially very helpful, because then consumers won't need to worry about manually providing a delay each time they use the component. On the other hand, it's possible there may be scenarios where it's necessary to customize the delay, e.g. by reducing it to 0 or by increasing it. If you migrate this component to EUI, I'd suggest thinking about that aspect some more. If it seems like the built-in delay is the way to go, I would suggest at least exposing some ability for consumers to override it. Thanks for tackling this stuff! |
@cjcenizal, thanks for the response! and sorry for the delay from my side :) What you typed seems very useful.
The 3rd option is what has been done for The 2nd option is just I think maybe useful, might be skipped. Looking at written above, I'm thinking that it seems as expanding search bar component's functionality by adding an additional tiny functional layer. How does it sound for you? |
|
UPDATED: #1876 updates the table caption in file |
Steps to reproduce (assumes ChromeVox or similar)
Long story short: All of these items need to trigger screen reader events when they change the content of the table they are connected to with, at the very least, the number of rows returned as a result of user action.
Actual Result
Expected Result
Category: #688: Elastic UI Tables Accessibility
Relevant WCAG Criteria: 3.2.2 Predictable: On Input
The text was updated successfully, but these errors were encountered: