Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] (Accessibility) "Opened", "Closed" Filter buttons need to announce number of results, also Group #28385

Closed
aphelionz opened this issue Jan 9, 2019 · 8 comments

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

  1. Navigate to the Machine Learning page, ensure there are a diverse set of jobs
  2. Tab to the "Opened" filter button
  3. Press enter

screenshot_20190109_121902

Actual Result

  1. The screen reader simply reads "Opened, button"

Expected Result

  1. The screen reader should announce something like "Results are filtered by opened, there is 1 result"

Meta Issue #26855

Kibana Version: 6.5

Relevant WCAG Criteria: 3.2.2 On Input

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@jgowdyelastic jgowdyelastic changed the title (Accessibility) "Opened", "Closed" Filter buttons need to announce number of results, also Group [ML] (Accessibility) "Opened", "Closed" Filter buttons need to announce number of results, also Group Jan 9, 2019
@peteharverson
Copy link
Contributor

Should look to add some screen reader content to the page, saying the number of jobs and the current filter on the jobs list.

@PhilippBaranovskiy
Copy link
Contributor

This issue is in progress,
the appropriate PR will be created once Delayed Rendering is ready to use.
DelayRender component PR

@PhilippBaranovskiy
Copy link
Contributor

Once 11.3.0 Eui version is merged into Kibana, this issue gets fixed automatically.

@PhilippBaranovskiy
Copy link
Contributor

@bhavyarm , could you have a look on this at the master branch and let us know that with VoiceOver new updated search combo box works great?
It should react on every change in the search field while leaving that field as well as filtering the list with toggle buttons. The buttons also now should be announce as "toggle button, not pressed" or something like that.
The reaction to the change is "Below is the list of {N} items" (or close to it).

@sophiec20 sophiec20 added Feature:Anomaly Detection ML anomaly detection and removed Feature:ml-results legacy - do not use labels Jun 19, 2019
@bhavyarm
Copy link
Contributor

@rockfield my x-pack didn't build. I am gonna be looking at this with snapshots tomorrow morning! thanks

@bhavyarm
Copy link
Contributor

@rockfield yep. It works fine. Closing it. Thanks!

@peteharverson
Copy link
Contributor

Closing as confirmed fixed for 7.3.0 by EuiDelayRender PR, added in EUI 11.3.2. Tested with NVDA screen reader, and content is read out e.g. 'Below is a table of 5 items' when toggling the filter buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants