Stack Monitoring: Add Enterprise Search monitoring index templates #82743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.1.0
external-contributor
carlosdelest
added
:Data Management/Monitoring
>enhancement
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
carlosdelest
requested review from
klacabane,
jasonrhodes,
sayden and
matschaffer
dakrone
requested changes
Jan 19, 2022
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/monitoring/MonitoredSystem.java
Outdated
Show resolved
Hide resolved
Comment on lines
+2
to
+3
| "index_patterns": [".monitoring-ent-search-${xpack.stack.monitoring.template.version}-*"], | ||
| "version": ${xpack.stack.monitoring.template.release.version}, |
There was a problem hiding this comment.
Can you add a _meta map that includes "managed": true and a "description" field for what this template is for?
There was a problem hiding this comment.
It looks like you added one to the monitoring-beats-mb.json file, but didn't add one for this template yet?
There was a problem hiding this comment.
🤦 Sorry for that. I actually modified it now instead of another random file 🤦
Thanks for catching this up, @dakrone 👍
6 tasks
3 tasks
carlosdelest
force-pushed
the
carlosdelest/add-enterprise-search-monitoring
branch
from
c8c2772 to
fe3a40b
Compare
matschaffer
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Approving on the basis that this does work in my testing, but I think @dakrone is probably right that adding to MonitoredSystem.java is probably not required for the only modes of monitoring we're planning for (internal collection via packaged metricbeat, or external via operator-controlled metricbeat).
dakrone
requested changes
Jan 24, 2022
Comment on lines
+2
to
+3
| "index_patterns": [".monitoring-ent-search-${xpack.stack.monitoring.template.version}-*"], | ||
| "version": ${xpack.stack.monitoring.template.release.version}, |
There was a problem hiding this comment.
It looks like you added one to the monitoring-beats-mb.json file, but didn't add one for this template yet?
dakrone
approved these changes
Jan 25, 2022
carlosdelest
deleted the
carlosdelest/add-enterprise-search-monitoring
branch
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jan 26, 2022
* upstream/master: (762 commits) [DOCS] Add note to that log4j customization is outside the support scope (elastic#82668) Batch Index Settings Update Requests (elastic#82896) [DOCS] Delete pipeline containing stored script (elastic#83102) Try again to fix changelog areas after reorg (elastic#83100) Bind to non-localhost for transport in some cases (elastic#82973) [DOCS] Reuse multi-level `join` warning (elastic#82976) Remove unnecessary CopyOnWriteHashMap class (elastic#83040) Adjust changelog categories after reorg (elastic#83087) [DOCS] Fix typo in `action.destructive_requires_name` breaking change (elastic#83085) Stack Monitoring: Add Enterprise Search monitoring index templates (elastic#82743) [DOCS] Fix stored script example snippet (elastic#83056) [DOCS] Re-add network traffic para to `term` query (elastic#83047) [DOCS] Rename example stored script (elastic#83054) [ML][DOCS] Add Trained model APIs to the REST APIs index (elastic#82791) [ML] Update running process when global calendar changes (elastic#83044) [Transform] Fix condition on which the transform stops processing buckets (elastic#82852) [DOCS] Fixes field names in ML sum functions. (elastic#83048) [ML] fix NLP tokenization never_split handling around punctuation (elastic#82982) Construct dynamic updates directly via object builders (elastic#81449) Emit trace.id into audit logs (elastic#82849) ... # Conflicts: # client/rest-high-level/src/test/java/org/elasticsearch/client/IndicesClientIT.java # client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/ILMDocumentationIT.java # server/src/main/java/org/elasticsearch/action/admin/indices/rollover/Condition.java # server/src/test/java/org/elasticsearch/action/admin/indices/rollover/ConditionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/RolloverActionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStepTests.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Enterprise Search monitoring template that will be automatically installed from the Monitoring plugin.
In 8.x, Enterprise Search Metricbeat module will include xpack.enabled mode in order to write to stack monitoring data streams (.monitoring--) instead of the current .metricbeat-* inidices. See elastic/beats#29871 for more details.
The new template creates the data stream for the Enterprise Search monitoring information. The template
.monitoring-ent-search-mbmatching on.monitoring-ent-search-8-*is defined inmonitoring-ent-search-mb.json.Related issues