-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add note to that log4j customization is outside the support scope #82668
Conversation
…out of support scope
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting that we make some changes to this note and not indicate any Support claims. I'd also like to get additional guidance before merging.
Co-authored-by: Adam Locke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ope (elastic#82668) * [docs] Add note to Elasticsearch logging that log4j customization is out of support scope * Update language for default logging recommendation Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Quin Hoxie <[email protected]> Co-authored-by: Adam Locke <[email protected]>
…ope (elastic#82668) * [docs] Add note to Elasticsearch logging that log4j customization is out of support scope * Update language for default logging recommendation Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Quin Hoxie <[email protected]> Co-authored-by: Adam Locke <[email protected]>
…ope (#82668) (#83112) * [docs] Add note to Elasticsearch logging that log4j customization is out of support scope * Update language for default logging recommendation Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Quin Hoxie <[email protected]> Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Toby Sutor <[email protected]> Co-authored-by: Quin Hoxie <[email protected]>
…ope (#82668) (#83113) * [docs] Add note to Elasticsearch logging that log4j customization is out of support scope * Update language for default logging recommendation Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Quin Hoxie <[email protected]> Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Toby Sutor <[email protected]> Co-authored-by: Quin Hoxie <[email protected]>
…ope (#82668) (#83114) * [docs] Add note to Elasticsearch logging that log4j customization is out of support scope * Update language for default logging recommendation Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Quin Hoxie <[email protected]> Co-authored-by: Adam Locke <[email protected]> Co-authored-by: Toby Sutor <[email protected]> Co-authored-by: Quin Hoxie <[email protected]>
* upstream/master: (762 commits) [DOCS] Add note to that log4j customization is outside the support scope (elastic#82668) Batch Index Settings Update Requests (elastic#82896) [DOCS] Delete pipeline containing stored script (elastic#83102) Try again to fix changelog areas after reorg (elastic#83100) Bind to non-localhost for transport in some cases (elastic#82973) [DOCS] Reuse multi-level `join` warning (elastic#82976) Remove unnecessary CopyOnWriteHashMap class (elastic#83040) Adjust changelog categories after reorg (elastic#83087) [DOCS] Fix typo in `action.destructive_requires_name` breaking change (elastic#83085) Stack Monitoring: Add Enterprise Search monitoring index templates (elastic#82743) [DOCS] Fix stored script example snippet (elastic#83056) [DOCS] Re-add network traffic para to `term` query (elastic#83047) [DOCS] Rename example stored script (elastic#83054) [ML][DOCS] Add Trained model APIs to the REST APIs index (elastic#82791) [ML] Update running process when global calendar changes (elastic#83044) [Transform] Fix condition on which the transform stops processing buckets (elastic#82852) [DOCS] Fixes field names in ML sum functions. (elastic#83048) [ML] fix NLP tokenization never_split handling around punctuation (elastic#82982) Construct dynamic updates directly via object builders (elastic#81449) Emit trace.id into audit logs (elastic#82849) ... # Conflicts: # client/rest-high-level/src/test/java/org/elasticsearch/client/IndicesClientIT.java # client/rest-high-level/src/test/java/org/elasticsearch/client/documentation/ILMDocumentationIT.java # server/src/main/java/org/elasticsearch/action/admin/indices/rollover/Condition.java # server/src/test/java/org/elasticsearch/action/admin/indices/rollover/ConditionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/RolloverActionTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/TimeseriesLifecycleTypeTests.java # x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/ilm/WaitForRolloverReadyStepTests.java
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
log4j is a third party library which is being used for Elasticsearch logging. Hence, log4j customizations are out of scope of the Elastic support offering (e.g.
I need to rollover every X days or XXXMB, with a naming pattern of x-y-dd-zz.json - how to do this?
) and this should be documented more prominently.