Fix bug with significant terms background count #76730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>bug
:Analytics/Aggregations
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
approved these changes
Aug 19, 2021
imotov
approved these changes
Aug 19, 2021
|
The test failure in elasticsearch-ci/part-2 is unrelated and is already tracked in #76689, restarting @elasticmachine run elasticsearch-ci/part-2 |
benwtrent
added
the
auto-backport
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 20, 2021
When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes elastic#76729
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 20, 2021
When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes elastic#76729
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Aug 20, 2021
benwtrent
added a commit
that referenced
this pull request
Aug 20, 2021
* Fix bug with significant terms background count (#76730) When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes #76729
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 20, 2021
* Fix bug with significant terms background count (#76730) When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes #76729 * fixing bwc yaml test version
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 20, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building empty responses for shards that don't have the term field in question,
significant terms ignored the background filter.
This commit fixes this bug by respecting the background filter count, even
when building empty results.
closes #76729