-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant terms ignores background filter #76729
Labels
:Analytics/Aggregations
Aggregations
>bug
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v7.15.0
v8.0.0-alpha2
Comments
elasticmachine
added
the
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
label
Aug 19, 2021
Pinging @elastic/es-analytics-geo (Team:Analytics) |
benwtrent
added a commit
that referenced
this issue
Aug 20, 2021
When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes #76729
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this issue
Aug 20, 2021
When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes elastic#76729
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this issue
Aug 20, 2021
When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes elastic#76729
benwtrent
added a commit
that referenced
this issue
Aug 20, 2021
* Fix bug with significant terms background count (#76730) When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes #76729
elasticsearchmachine
pushed a commit
that referenced
this issue
Aug 20, 2021
* Fix bug with significant terms background count (#76730) When building empty responses for shards that don't have the term field in question, significant terms ignored the background filter. This commit fixes this bug by respecting the background filter count, even when building empty results. closes #76729 * fixing bwc yaml test version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Aggregations
Aggregations
>bug
Team:Analytics
Meta label for analytical engine team (ESQL/Aggs/Geo)
v7.15.0
v8.0.0-alpha2
Elasticsearch version (
bin/elasticsearch --version
):7.15 (and probably earlier)
Description of the problem including expected versus actual behavior:
Significant terms is ignoring the background filter when one index has NO documents containing the term value.
Steps to reproduce:
Here are a long set of steps to reproduce
With the background filter, one expects the background count to be only
5
docsBut, it responds with:
"bg_count" : 8,
Which means the 3 docs that don't match the filter were matched.
Seems like a bad optimization as those docs also don't contain the term field
field3
The text was updated successfully, but these errors were encountered: