Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] APM Correlations: Fix API integration tests. #111532

Merged

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 8, 2021

Summary

Follow up to elastic/elasticsearch#76730

Fixes #109583
Fixes #109703
Fixes #109660

A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.

Checklist

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@qn895
Copy link
Member

qn895 commented Sep 8, 2021

LGTM 🎉

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 8, 2021
@walterra walterra merged commit 28af11a into elastic:master Sep 8, 2021
@walterra walterra deleted the ml-apm-fix-api-integration-tests-1 branch September 8, 2021 19:33
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 8, 2021
A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.15 Commit could not be cherrypicked due to conflicts
7.x

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 111532

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Sep 8, 2021
A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.
kibanamachine added a commit that referenced this pull request Sep 8, 2021
A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.

Co-authored-by: Walter Rafelsberger <[email protected]>
walterra added a commit to walterra/kibana that referenced this pull request Sep 8, 2021
A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.
# Conflicts:
#	x-pack/test/apm_api_integration/tests/correlations/failed_transactions.ts
walterra added a commit that referenced this pull request Sep 9, 2021
…111658)

* [ML] APM Correlations: Fix API integration tests. (#111532)

A bugfix for significant terms on the ES side resulted in changes to assertions we have for api integration tests for APM correlations. This PR updates the affected tests.
# Conflicts:
#	x-pack/test/apm_api_integration/tests/correlations/failed_transactions.ts

* [ML] Fix assertion value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment