Introduce ?wait_for_active_shards=index-setting #67158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 7.x the close indices API defaulted to `?wait_for_active_shards=0` but from 8.0 it defaults to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and emits a deprecation warning indicating that the default no longer needs to be used and will be unsupported in future. In 7.x a follow up PR will introduce support for the same `index-setting` value for this parameter and will emit deprecation warnings if users try and use the default instead. Relates elastic#66419
DaveCTurner
added
>bug
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Jan 11, 2021
|
Thanks @tlrx |
DaveCTurner
deleted the
2021-01-07-deprecate-wait_for_active_shards-default-for-close-index
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 11, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates elastic#67158 Closes elastic#66419
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 12, 2021
Some changes for `master` that make elastic#67246 a bit easier. Relates elastic#67158
DaveCTurner
added a commit
that referenced
this pull request
Jan 13, 2021
DaveCTurner
added a commit
that referenced
this pull request
Jan 13, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates #67158 Closes #66419
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 14, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates elastic#67158 Retry of elastic#67246 now that elastic#67498 is merged to `master` Closes elastic#66419
DaveCTurner
added a commit
that referenced
this pull request
Jan 14, 2021
In 7.x the close indices API defaults to `?wait_for_active_shards=0` but from 8.0 it will default to respecting the index settings instead. This commit introduces the `index-setting` value for this parameter on this API allowing users to opt-in to the future behaviour today, and starts to emit a deprecation warning for users that use the default. Relates #67158 Retry of #67246 now that #67498 is merged to `master` Closes #66419
pgomulka
added a commit
that referenced
this pull request
Jul 15, 2021
masseyke
pushed a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 16, 2021
…c#75187) Warning related transformations missed the possibility to apply per single test only. Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test relates elastic#51816
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…c#75187) Warning related transformations missed the possibility to apply per single test only. Also a warning changed in elastic#67158 for indices.close so this PR also applies the transformation for 7.x test relates elastic#51816
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 14, 2024
…e API Specifiying `wait_for_active_shards=index-setting` was deprecared in elastic#67158 (8.0). It's redundant since it's the default behaviour in 8.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.x the close indices API defaulted to
?wait_for_active_shards=0but from 8.0 it defaults to respecting the index settings instead. This
commit introduces the
index-settingvalue for this parameter on thisAPI allowing users to opt-in to the future behaviour today, and emits a
deprecation warning indicating that the default no longer needs to be
used and will be unsupported in future.
In 7.x a follow up PR will introduce support for the same
index-settingvalue for this parameter and will emit deprecationwarnings if users try and use the default instead.
Relates #66419