Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for wait_for_active_shards=index-setting in index close API #114709

Closed
wants to merge 19 commits into from
Closed

Remove support for wait_for_active_shards=index-setting in index close API #114709

wants to merge 19 commits into from

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Oct 14, 2024

Specifiying wait_for_active_shards=index-setting was deprecared in #67158 (8.0). It's redundant since it's the default behaviour in 8.x

@arteam
Remove support for wait_for_active_shards=index-setting in index clos…
a74b605 
…e API

Specifiying `wait_for_active_shards=index-setting` was deprecared in elastic#67158 (8.0).
It's redundant since it's the default behaviour in 8.x
@arteam arteam added >breaking :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. labels Oct 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

DaveCTurner
DaveCTurner reviewed Oct 14, 2024
View reviewed changes
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestCloseIndexAction.java Outdated
// TODO in v9:
// - throw an IllegalArgumentException here
// - record the removal of support for this value as a breaking change
throw new IllegalArgumentException("wait_for_active_shards=index-setting shouldn't be used");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to preserve the v8 behaviour here still if RestApiVersion.V_8 is specified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just saw a comment about that in the dev issue 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 that applies to all other similar breaking changes too btw

arteam added 11 commits October 14, 2024 15:41
@arteam arteam added the WIP label Oct 17, 2024
@arteam arteam removed the WIP label Oct 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you. Note that since this PR is labelled >breaking, you need to update the changelog YAML to fill out the extended information sections.

@arteam
Copy link
Contributor Author

arteam commented Oct 17, 2024

@elasticmachine update branch

@arteam arteam added the :Data Management/Indices APIs APIs to create and manage indices and templates label Oct 24, 2024
@arteam
Copy link
Contributor Author

arteam commented Nov 14, 2024

The issue is now owned by the Data Management team, see #115837.

@arteam arteam closed this Nov 14, 2024
@arteam arteam deleted the remove-support-wait-for-active-shards-index-settings branch November 14, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner left review comments

Assignees
No one assigned
Labels
>breaking :Data Management/Indices APIs APIs to create and manage indices and templates :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arteam @elasticsearchmachine @DaveCTurner @elasticmachine