Respect CloseIndexRequest#waitForActiveShards in HLRC #67374
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes for `master` that make elastic#67246 a bit easier. Relates elastic#67158
DaveCTurner
added
>bug
:Distributed Indexing/Distributed
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Jan 12, 2021
| @@ -137,6 +137,7 @@ static Request closeIndex(CloseIndexRequest closeIndexRequest) { | |||
| parameters.withTimeout(closeIndexRequest.timeout()); | |||
| parameters.withMasterTimeout(closeIndexRequest.masterNodeTimeout()); | |||
| parameters.withIndicesOptions(closeIndexRequest.indicesOptions()); | |||
| parameters.withWaitForActiveShards(closeIndexRequest.waitForActiveShards()); | |||
There was a problem hiding this comment.
This is actually a bugfix, we didn't respect this parameter before this change.
tlrx
approved these changes
Jan 13, 2021
| @@ -137,6 +137,7 @@ static Request closeIndex(CloseIndexRequest closeIndexRequest) { | |||
| parameters.withTimeout(closeIndexRequest.timeout()); | |||
| parameters.withMasterTimeout(closeIndexRequest.masterNodeTimeout()); | |||
| parameters.withIndicesOptions(closeIndexRequest.indicesOptions()); | |||
| parameters.withWaitForActiveShards(closeIndexRequest.waitForActiveShards()); | |||
DaveCTurner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes for
masterthat make #67246 a bit easier.Relates #67158