-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Painless context doc updates for scripted metric aggregation "state" context variables #32695
Merged
rjernst
merged 2 commits into
elastic:master
from
rationull:rationull/scripted-metric-agg-state-painless-context-docs
Aug 10, 2018
Merged
Painless context doc updates for scripted metric aggregation "state" context variables #32695
rjernst
merged 2 commits into
elastic:master
from
rationull:rationull/scripted-metric-agg-state-painless-context-docs
Aug 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge from params["_agg"] to 'state' context variable
rationull
changed the title
Modify painless context docs for scripted metric aggregation for chan…
Painless context doc updates for scripted metric aggregation "state" context variables
Aug 8, 2018
rjernst
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine ok to test |
rjernst
added
>docs
General docs changes
:Analytics/Aggregations
Aggregations
v7.0.0
v6.5.0
labels
Aug 9, 2018
Pinging @elastic/es-search-aggs |
@rationull can you sync with master? I think the failure is unrelated |
@rjernst done -- let's see how this one turns out. |
@elasticmachine test this please |
Thanks @rationull! |
rjernst
pushed a commit
that referenced
this pull request
Aug 10, 2018
This change brings the scripted metric agg context docs in line with the new agg state context variable.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 13, 2018
…listeners * elastic/master: (58 commits) [ML] Partition-wise maximum scores (elastic#32748) [DOCS] XContentBuilder#bytes method removed, using BytesReference.bytes(docBuilder) (elastic#32771) HLRC: migration get assistance API (elastic#32744) Add a task to run forbiddenapis using cli (elastic#32076) [Kerberos] Add debug log statement for exceptions (elastic#32663) Make x-pack core pull transport-nio (elastic#32757) Painless: Clean Up Whitelist Names (elastic#32791) Cat apis: Fix index creation time to use strict date format (elastic#32510) Clear Job#finished_time when it is opened (elastic#32605) (elastic#32755) Test: Only sniff host metadata for node_selectors (elastic#32750) Update scripted metric docs to use `state` variable (elastic#32695) Painless: Clean up PainlessCast (elastic#32754) [TEST] Certificate NONE not allowed in FIPS JVM (elastic#32753) [ML] Refactor ProcessCtrl into Autodetect and Normalizer builders (elastic#32720) Access build tools resources (elastic#32201) Tests: Disable rolling upgrade tests with system key on fips JVM (elastic#32775) HLRC: Ban LoggingDeprecationHandler (elastic#32756) Fix test reproducability in AbstractBuilderTestCase setup (elastic#32403) Only require java<version>_home env var if needed Tests: Muted ScriptDocValuesDatesTests.testJodaTimeBwc ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes that this doc refers too were implemented for #29328. The PR that officially deprecates the old functionality is still open (#31597) but the new names are in place on the 6.4 branch.
This change brings the scripted metric agg context docs in line with the new agg state context variable.