Cat apis: Fix index creation time to use strict date format #32510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the move to java time, the default formatter used by toString on ZonedDateTime uses optional components for least significant portions of the date. This commit changes the cat indices api to use a strict date time format, which will always output milliseconds, even if they are zero. closes elastic#32466
rjernst
added
>bug
:Data Management/CAT APIs
|
Pinging @elastic/es-core-infra |
spinscale
approved these changes
Jul 31, 2018
| @@ -39,6 +39,8 @@ | |||
| import org.elasticsearch.common.Strings; | |||
| import org.elasticsearch.common.Table; | |||
| import org.elasticsearch.common.settings.Settings; | |||
| import org.elasticsearch.common.time.CompoundDateTimeFormatter; | |||
rjernst
force-pushed
the
cat_creation_time
branch
from
66d94d3 to
6f70b05
Compare
|
@davidkyle This doesn't actually fix the issue at the moment. While this PR passes CI, it can fail in the same way the current code does. Once #32592, I can update this PR again and it will fix #32466 |
rjernst
added a commit
that referenced
this pull request
Aug 10, 2018
With the move to java time, the default formatter used by toString on ZonedDateTime uses optional components for least significant portions of the date. This commit changes the cat indices api to use a strict date time format, which will always output milliseconds, even if they are zero. closes #32466
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 13, 2018
…listeners * elastic/master: (58 commits) [ML] Partition-wise maximum scores (elastic#32748) [DOCS] XContentBuilder#bytes method removed, using BytesReference.bytes(docBuilder) (elastic#32771) HLRC: migration get assistance API (elastic#32744) Add a task to run forbiddenapis using cli (elastic#32076) [Kerberos] Add debug log statement for exceptions (elastic#32663) Make x-pack core pull transport-nio (elastic#32757) Painless: Clean Up Whitelist Names (elastic#32791) Cat apis: Fix index creation time to use strict date format (elastic#32510) Clear Job#finished_time when it is opened (elastic#32605) (elastic#32755) Test: Only sniff host metadata for node_selectors (elastic#32750) Update scripted metric docs to use `state` variable (elastic#32695) Painless: Clean up PainlessCast (elastic#32754) [TEST] Certificate NONE not allowed in FIPS JVM (elastic#32753) [ML] Refactor ProcessCtrl into Autodetect and Normalizer builders (elastic#32720) Access build tools resources (elastic#32201) Tests: Disable rolling upgrade tests with system key on fips JVM (elastic#32775) HLRC: Ban LoggingDeprecationHandler (elastic#32756) Fix test reproducability in AbstractBuilderTestCase setup (elastic#32403) Only require java<version>_home env var if needed Tests: Muted ScriptDocValuesDatesTests.testJodaTimeBwc ...
rjernst
added a commit
that referenced
this pull request
Aug 14, 2018
With the move to java time, the default formatter used by toString on ZonedDateTime uses optional components for least significant portions of the date. This commit changes the cat indices api to use a strict date time format, which will always output milliseconds, even if they are zero. closes #32466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to java time, the default formatter used by toString on
ZonedDateTime uses optional components for least significant portions of
the date. This commit changes the cat indices api to use a strict date
time format, which will always output milliseconds, even if they are
zero.
closes #32466