Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] 'finished_time' still reported after job has been reopened #32605

Closed
dolaru opened this issue Aug 3, 2018 · 2 comments
Closed

[ML] 'finished_time' still reported after job has been reopened #32605

dolaru opened this issue Aug 3, 2018 · 2 comments
Labels
>bug :ml Machine learning

Comments

@dolaru
Copy link
Member

dolaru commented Aug 3, 2018

Description

Found in 6.3.2

Currently, when a job closes, the finished_time key is created/updated in the job config and it's value represents the timestamp of when the job was last closed.

If the user reopens the job, we still show the last finished_time until the job closes again. This is misleading, as there shouldn't be a finished_time reported while a job is still open.

Steps to reproduce

  1. Create a job
  2. Open the job
  3. Close the job
  4. Re-open the job
  5. Notice that finished_time is still being reported and the value coincides with the time at which the job was last closed.
@dolaru dolaru added >bug :ml Machine learning labels Aug 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

benwtrent added a commit to benwtrent/elasticsearch that referenced this issue Aug 9, 2018
@benwtrent
Clear Job#finished_time when it is opened (elastic#32605)
08218af
benwtrent added a commit that referenced this issue Aug 10, 2018
@benwtrent
Clear Job#finished_time when it is opened (#32605) (#32755)
b08416b 
* Clear Job#finished_time when it is opened (#32605)

* not returning failure when Job#finished_time is not reset

* Changing error log string and source string
benwtrent added a commit that referenced this issue Aug 10, 2018
@benwtrent
Clear Job#finished_time when it is opened (#32605) (#32755)
e6e2cda 
* Clear Job#finished_time when it is opened (#32605)

* not returning failure when Job#finished_time is not reset

* Changing error log string and source string
@benwtrent
Copy link
Member

#32755 fixes this issue

jasontedor added a commit to jasontedor/elasticsearch that referenced this issue Aug 13, 2018
@jasontedor
Merge remote-tracking branch 'elastic/master' into global-checkpoint-…
50a9a6c 
…listeners

* elastic/master: (58 commits)
  [ML] Partition-wise maximum scores (elastic#32748)
  [DOCS] XContentBuilder#bytes method removed, using BytesReference.bytes(docBuilder) (elastic#32771)
  HLRC: migration get assistance API (elastic#32744)
  Add a task to run forbiddenapis using cli (elastic#32076)
  [Kerberos] Add debug log statement for exceptions (elastic#32663)
  Make x-pack core pull transport-nio (elastic#32757)
  Painless: Clean Up Whitelist Names (elastic#32791)
  Cat apis: Fix index creation time to use strict date format (elastic#32510)
  Clear Job#finished_time when it is opened (elastic#32605) (elastic#32755)
  Test: Only sniff host metadata for node_selectors (elastic#32750)
  Update scripted metric docs to use `state` variable (elastic#32695)
  Painless: Clean up PainlessCast (elastic#32754)
  [TEST] Certificate NONE not allowed in FIPS JVM (elastic#32753)
  [ML] Refactor ProcessCtrl into Autodetect and Normalizer builders (elastic#32720)
  Access build tools resources (elastic#32201)
  Tests: Disable rolling upgrade tests with system key on fips JVM (elastic#32775)
  HLRC: Ban LoggingDeprecationHandler (elastic#32756)
  Fix test reproducability in AbstractBuilderTestCase setup (elastic#32403)
  Only require java<version>_home env var if needed
  Tests: Muted ScriptDocValuesDatesTests.testJodaTimeBwc
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :ml Machine learning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dolaru @benwtrent @elasticmachine