Updating package-spec dependency

[ycombinator]

This PR updates the dependency on the package-spec to bring in this change: elastic/package-spec#139.

Related: elastic/package-spec#106

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: Pull request #260 updated

• Start Time: 2021-02-25T17:49:15.131+0000

• Duration: 18 min 21 sec

• Commit: ba99682

Test stats 🧪

Test	Results
Failed	0
Passed	292
Skipped	1
Total	293

Trends 🧪

[ycombinator]

CI is failing with this error:

[2021-02-23T00:59:28.131Z] ERROR: for elastic-agent_is_ready  Container "c1071590ccd8" is unhealthy.

[2021-02-23T00:59:28.131Z] Encountered errors while bringing up the project.

[2021-02-23T00:59:28.131Z] Error: booting up the stack failed: running docker-compose failed: running command failed: running Docker Compose up command failed: exit status 1

I believe this is due to recent changes in elastic-agent behavior which are going to be fixed in a new Docker image shortly. So we will simply retry CI again in a day or so.

[mtojek]

/test

[mtojek]

The change looks good to me, but please wait for the green status.

[mtojek]

Blocked by: elastic/beats#24163

[mtojek]

@ycombinator I think it failed due to some issues around event.ingested.

[ycombinator]

@mtojek I ended up making some more code changes to this PR even after applying the changes from #263. So I have re-requested your review. Thanks!

[mtojek]

Just a loose thought:

Personally I think that this is an overkill here (switch from JSON to YAML), because eventually we'll end up with correcting these files mostly on our own :)

IMHO you could go without deprecation period, but of course it's clearer.

Apart from this, LGTM!

[ycombinator]

Personally I think that this is an overkill here (switch from JSON to YAML), because eventually we'll end up with correcting these files mostly on our own :)

IMHO you could go without deprecation period, but of course it's clearer.

Yeah, I agree about this when it comes to packages in integrations. The deprecation period is more for packages that are being developed outside of the integrations repo that we don't really know about. I doubt any of them are using pipeline tests but, just in case they are, better to be safe!