Temporarily hardcode agent image reference #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
reviewed
Feb 24, 2021
| @@ -75,7 +75,7 @@ services: | |||
| condition: service_healthy | |||
|
|
|||
| elastic-agent: | |||
| image: docker.elastic.co/beats/elastic-agent:${STACK_VERSION} | |||
| image: docker.elastic.co/beats/elastic-agent@sha256:75c9fbf835a7d24166bceb82f28f4c6c5d00048ba9f0a25b945818e4cf2bba69 | |||
There was a problem hiding this comment.
Could you add a screaming comment here saying this is a temporary hack and should be removed once #261 goes green? Just in case we somehow forget about it. 😅
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mtojek
pushed a commit
to mtojek/elastic-package
that referenced
this pull request
Feb 25, 2021
This reverts commit fb7942f.
mtojek
added a commit
that referenced
this pull request
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will temporarily hardcode the Docker image reference for Elastic Agent to the stable image. Unfortunately this fix will cause that 7.12.0-SNAPSHOT will be the only working one, but most likely will unblock development.
Related: elastic/beats#24198