Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating JSON-formatted pipeline test configs in favor of YAML-formatted ones #139

Merged
merged 6 commits into from
Feb 22, 2021

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Feb 19, 2021

What does this PR do?

This PR deprecates the JSON-formatted (*.json) pipeline test configuration files in favor of YAML-formatted (*.yml) ones.

Why is it important?

To bring consistency, since all other package configuration / metadata files are formatted as YAML.

Checklist

Related issues

@elasticmachine
Copy link

elasticmachine commented Feb 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #139 updated

  • Start Time: 2021-02-19T17:12:30.618+0000

  • Duration: 7 min 7 sec

  • Commit: ebb4083

Trends 🧪

Image of Build Times

@ycombinator ycombinator marked this pull request as ready for review February 19, 2021 17:20
@ycombinator ycombinator requested a review from mtojek February 19, 2021 17:20
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! Most likely you will need followups in integrations and elastic-package (+docs).

@ycombinator ycombinator merged commit 5411166 into elastic:master Feb 22, 2021
@ycombinator ycombinator deleted the pipeline-test-config-yml branch February 22, 2021 22:58
@ycombinator ycombinator mentioned this pull request Mar 16, 2021
2 tasks
rw-access pushed a commit to rw-access/package-spec that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants