Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Fix position of done call in Log level test #260

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

This changes the position of a waitgroup Done() call to fix a potential panic, as we can occasionally hit the gotStopped call more than once. The rest of the tests already do this, I just forgot to adjust this test.

Why is it important?

This can cause occasional test failures.

@fearful-symmetry fearful-symmetry added bug Something isn't working Team:Elastic-Agent Label for the Agent team labels Feb 27, 2023
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner February 27, 2023 19:02
@fearful-symmetry fearful-symmetry self-assigned this Feb 27, 2023
@fearful-symmetry fearful-symmetry requested review from cmacknz and faec and removed request for a team February 27, 2023 19:02
@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-27T19:02:31.514+0000

  • Duration: 12 min 48 sec

Steps errors 1

Expand to view the steps failures

Go unitTest
  • Took 0 min 29 sec . View more details here
  • Description: mage unitTest

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@leehinman leehinman merged commit fff35d3 into elastic:main Feb 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants