Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Fix position of done call in Log level test #260

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix position of done call in Log level test #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions controller/controller_client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,6 @@ func TestUnitLogChange(t *testing.T) {
t.FailNow()
}
if gotStopped {
doneWaiter.Done()
return nil
}
// initial checkin
Expand Down Expand Up @@ -540,7 +539,7 @@ func TestUnitLogChange(t *testing.T) {
}
} else if unitsAreState(t, proto.State_HEALTHY, observed.Units) && gotHealthy {
// shut down
t.Logf("Got unit state healthy, stoppinng")
t.Logf("Got unit state healthy, stopping")
//check to see if log level has changed
observedLogLevel = logp.GetLevel()
unitOut.ConfigStateIdx++
Expand All @@ -552,7 +551,7 @@ func TestUnitLogChange(t *testing.T) {
}
} else if unitsAreState(t, proto.State_STOPPED, observed.Units) {
gotStopped = true
//doneWaiter.Done()
doneWaiter.Done()
t.Logf("Got unit state STOPPED, removing")
return &proto.CheckinExpected{
Units: []*proto.UnitExpected{},
Expand Down