fix position of done call in Log test (#260)

elastic · Feb 27, 2023 · fff35d3 · fff35d3
1 parent cdf8aa3
commit fff35d3
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/controller/controller_client_test.go b/controller/controller_client_test.go
@@ -506,7 +506,6 @@ func TestUnitLogChange(t *testing.T) {
 				t.FailNow()
 			}
 			if gotStopped {
-				doneWaiter.Done()
 				return nil
 			}
 			// initial checkin
@@ -540,7 +539,7 @@ func TestUnitLogChange(t *testing.T) {
 				}
 			} else if unitsAreState(t, proto.State_HEALTHY, observed.Units) && gotHealthy {
 				// shut down
-				t.Logf("Got unit state healthy, stoppinng")
+				t.Logf("Got unit state healthy, stopping")
 				//check to see if log level has changed
 				observedLogLevel = logp.GetLevel()
 				unitOut.ConfigStateIdx++
@@ -552,7 +551,7 @@ func TestUnitLogChange(t *testing.T) {
 				}
 			} else if unitsAreState(t, proto.State_STOPPED, observed.Units) {
 				gotStopped = true
-				//doneWaiter.Done()
+				doneWaiter.Done()
 				t.Logf("Got unit state STOPPED, removing")
 				return &proto.CheckinExpected{
 					Units: []*proto.UnitExpected{},