Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra build step #1337

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Remove extra build step #1337

merged 2 commits into from
Sep 11, 2023

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Sep 11, 2023

looks like Build already includes a call to BuildOpaBundle:

cloudbeat/magefile.go

Lines 81 to 84 in 48e17af

func Build() error {
mg.Deps(BuildOpaBundle)
return devtools.Build(devtools.DefaultBuildArgs())
}

@mergify mergify bot assigned orouz Sep 11, 2023
@mergify
Copy link

mergify bot commented Sep 11, 2023

This pull request does not have a backport label. Could you fix it @orouz? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

@orouz orouz marked this pull request as ready for review September 11, 2023 13:49
@orouz orouz requested a review from a team as a code owner September 11, 2023 13:49
@orouz orouz enabled auto-merge (squash) September 11, 2023 13:49
@orouz orouz disabled auto-merge September 11, 2023 14:28
@orouz
Copy link
Collaborator Author

orouz commented Sep 11, 2023

the bundle is removed after the function is done, looks like it's just there to ensure the build successeds. maybe we can remove the dep from Build()? it removes the temp dir, bundle is kept

cloudbeat/magefile.go

Lines 353 to 359 in 763e703

defer func() {
rmErr := os.RemoveAll(cspPoliciesPkgDir)
if rmErr != nil && err == nil {
err = rmErr
}
signal.Stop(c)
}()

@orestisfl wdyt?

@orouz orouz merged commit e06983c into elastic:main Sep 11, 2023
orestisfl pushed a commit to jeniawhite/cloudbeat that referenced this pull request Sep 18, 2023
jeniawhite added a commit that referenced this pull request Sep 22, 2023
* Implement Azure benchmark

* Fixing CR

* fixes

* [CloudFormation] Verify installation of cfn-signal (#1328)

* Bump magefile/mage-action from 2 to 3 in /.github/workflows (#1333)

Bumps [magefile/mage-action](https://github.com/magefile/mage-action) from 2 to 3.
- [Release notes](https://github.com/magefile/mage-action/releases)
- [Commits](magefile/mage-action@v2...v3)

---
updated-dependencies:
- dependency-name: magefile/mage-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* go.mod: Organize require blocks and update SDKs (#1330)

* Organize go.mod require blocks
* Update SDKs
* Remove go-errors/errors usage

* [CIS GCP] Add log bucket type to asset fetcher (#1327)

* add log bucket type

* bump cis policies version

* Rename factory package to preset (#1334)

* pre-commit: golangci-lint: Auto fix supported failures (#1336)

* Create a dedicated AWS organization preset (#1335)

* factory.NewCisAzureFactory

* Remove extra build step (#1337)

* AWS CSPM Resources add ECS data (#1312)

* Populate vulnerability.reference with a link to NVD (#1303)

* opulate vulnerability.reference with a link to NVD

* revert the if statemenet

* [Cloud Security] [Telemetry] fix package policy vars to use posture field (#1325)

fix package policy vars to use posture field

* Use branches to get bundles (#1332)

* Refactor to be compatible with main and fix compilation

* Fixing linter

* Adding unit tests

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Orestis Floros <[email protected]>
Co-authored-by: Amir Ben Nun <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Uri Weisman <[email protected]>
Co-authored-by: Or Ouziel <[email protected]>
Co-authored-by: Maxim Kholod <[email protected]>
Co-authored-by: Lola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants