Rename factory package to preset #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @amirbenun? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
orestisfl
approved these changes
Sep 11, 2023
| @@ -15,7 +15,7 @@ | |||
| // specific language governing permissions and limitations | |||
| // under the License. | |||
|
|
|||
| package factory | |||
| package preset | |||
There was a problem hiding this comment.
I have no idea for a better name here, maybe init? resources/fetching/init makes sense to me but I admit is not the most creative name.
There was a problem hiding this comment.
In go there's the init function so it might create a confusion.
I think preset describes well the idea of the package
orestisfl
pushed a commit
to jeniawhite/cloudbeat
that referenced
this pull request
Sep 18, 2023
jeniawhite
added a commit
that referenced
this pull request
Sep 22, 2023
* Implement Azure benchmark * Fixing CR * fixes * [CloudFormation] Verify installation of cfn-signal (#1328) * Bump magefile/mage-action from 2 to 3 in /.github/workflows (#1333) Bumps [magefile/mage-action](https://github.com/magefile/mage-action) from 2 to 3. - [Release notes](https://github.com/magefile/mage-action/releases) - [Commits](magefile/mage-action@v2...v3) --- updated-dependencies: - dependency-name: magefile/mage-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * go.mod: Organize require blocks and update SDKs (#1330) * Organize go.mod require blocks * Update SDKs * Remove go-errors/errors usage * [CIS GCP] Add log bucket type to asset fetcher (#1327) * add log bucket type * bump cis policies version * Rename factory package to preset (#1334) * pre-commit: golangci-lint: Auto fix supported failures (#1336) * Create a dedicated AWS organization preset (#1335) * factory.NewCisAzureFactory * Remove extra build step (#1337) * AWS CSPM Resources add ECS data (#1312) * Populate vulnerability.reference with a link to NVD (#1303) * opulate vulnerability.reference with a link to NVD * revert the if statemenet * [Cloud Security] [Telemetry] fix package policy vars to use posture field (#1325) fix package policy vars to use posture field * Use branches to get bundles (#1332) * Refactor to be compatible with main and fix compilation * Fixing linter * Adding unit tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Orestis Floros <[email protected]> Co-authored-by: Amir Ben Nun <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Uri Weisman <[email protected]> Co-authored-by: Or Ouziel <[email protected]> Co-authored-by: Maxim Kholod <[email protected]> Co-authored-by: Lola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
In this PR no logic has changed, only renaming of files, folders and functions
resources/fetching/factorypackage topreset.New...FactorytoNew...Fetchers.FetchersMapandRegisteredFetchermoved fromfactorypackage toregistryScreenshot/Data
Related Issues
Checklist