Populate vulnerability.reference with a link to NVD #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcold
commented
Aug 31, 2023
| @@ -73,3 +73,4 @@ terraform.rc | |||
| # Vulnerability management | |||
| db/ | |||
| fanal/ | |||
| java-db/ | |||
There was a problem hiding this comment.
not sure if it's smth specific to my machine or not, but I had this untracked dir after running cloudbeat locally with vulnerabilities yaml
maxcold
commented
Aug 31, 2023
vulnerability/events_creator.go
Outdated
| return vul.PrimaryURL | ||
| } | ||
|
|
||
| if _, ok := vul.CVSS[trivyVul.NVD]; ok { |
There was a problem hiding this comment.
I'm assuming that if there is a NVD in CVSS then this vulnerability exists in NVD database and the link will be valid. It's a bit brittle in my opinion, but if we want to replace aquasec links that's the simplest way I could find
There was a problem hiding this comment.
Also, as far as I understand this is the same solution we have today in kibana, right?
There was a problem hiding this comment.
nit: invert the if
if _, ok := vul.CVSS[trivyVul.NVD]; !ok {
return vul.PrimaryURL
}
📊 Allure Report - 💚 No failures were reported.
|
1 task
amirbenun
approved these changes
Sep 5, 2023
vulnerability/events_creator.go
Outdated
| return vul.PrimaryURL | ||
| } | ||
|
|
||
| if _, ok := vul.CVSS[trivyVul.NVD]; ok { |
There was a problem hiding this comment.
nit: invert the if
if _, ok := vul.CVSS[trivyVul.NVD]; !ok {
return vul.PrimaryURL
}
|
@amirbenun updated in case you want to take a look |
maxcold
force-pushed
the
869-populate-vulnerabilityreference-with-a-link-to-nvd-rather-then-aquasec-domain
branch
from
1151388 to
00a6faa
Compare
…ink-to-nvd-rather-then-aquasec-domain
…ink-to-nvd-rather-then-aquasec-domain
maxcold
deleted the
869-populate-vulnerabilityreference-with-a-link-to-nvd-rather-then-aquasec-domain
branch
maxcold
added a commit
to elastic/kibana
that referenced
this pull request
Sep 12, 2023
## Summary - fixes: elastic/security-team#7490 The NVD generation logic will be happening on the `cloudbeat` side after elastic/cloudbeat#869 (comment) is done and elastic/cloudbeat#1303 is merged, so we can remove the logic from Kibana and use what's in `vulnerability.reference` --------- Co-authored-by: kibanamachine <[email protected]>
orestisfl
pushed a commit
to jeniawhite/cloudbeat
that referenced
this pull request
Sep 18, 2023
* opulate vulnerability.reference with a link to NVD * revert the if statemenet
jeniawhite
added a commit
that referenced
this pull request
Sep 22, 2023
* Implement Azure benchmark * Fixing CR * fixes * [CloudFormation] Verify installation of cfn-signal (#1328) * Bump magefile/mage-action from 2 to 3 in /.github/workflows (#1333) Bumps [magefile/mage-action](https://github.com/magefile/mage-action) from 2 to 3. - [Release notes](https://github.com/magefile/mage-action/releases) - [Commits](magefile/mage-action@v2...v3) --- updated-dependencies: - dependency-name: magefile/mage-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * go.mod: Organize require blocks and update SDKs (#1330) * Organize go.mod require blocks * Update SDKs * Remove go-errors/errors usage * [CIS GCP] Add log bucket type to asset fetcher (#1327) * add log bucket type * bump cis policies version * Rename factory package to preset (#1334) * pre-commit: golangci-lint: Auto fix supported failures (#1336) * Create a dedicated AWS organization preset (#1335) * factory.NewCisAzureFactory * Remove extra build step (#1337) * AWS CSPM Resources add ECS data (#1312) * Populate vulnerability.reference with a link to NVD (#1303) * opulate vulnerability.reference with a link to NVD * revert the if statemenet * [Cloud Security] [Telemetry] fix package policy vars to use posture field (#1325) fix package policy vars to use posture field * Use branches to get bundles (#1332) * Refactor to be compatible with main and fix compilation * Fixing linter * Adding unit tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Orestis Floros <[email protected]> Co-authored-by: Amir Ben Nun <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Uri Weisman <[email protected]> Co-authored-by: Or Ouziel <[email protected]> Co-authored-by: Maxim Kholod <[email protected]> Co-authored-by: Lola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
This PR moves the logic existing in Kibana to Cloudbeat of populating the NVD link instead of the Aquasec link in
vulnerability.referencefield.Screenshot/Data
the field should look like the following after the change
Related Issues
Checklist